Re: [PATCH] make ide-cd handle non-2kB sector sizes

Jens Axboe
2004-01-23T16:18:53Z

On Fri, Jan 23 2004, Bartlomiej Zolnierkiewicz wrote:
> On Friday 23 of January 2004 15:01, Pascal Schmidt wrote:
> > On Fri, 23 Jan 2004, Jens Axboe wrote:
> > > It's a good first start, thanks for doing this. You really want to be
> > > storing this info in the queue, though, there's a hardsector size just
> > > for this very purpose. That way other layers know about the hardware
> > > sector size as well, not just ide-cd. And you get other things right for
> > > free as well, for instance ide_cdrom_prep_fs() needs a correct hardware
> > > block size or it will build wrong cdbs.
> >
> > Hmmm. I'm doing
> >
> > blk_queue_hardsect_size(drive->queue, sectors_per_frame << 9);
> >
> > inside of cdrom_read_toc, is that not enough? Or do you mean that
> > I should only store it in the queue and not also in cdrom_state_flags?
>
> I think Jens means storing it only in q->hardsect_size. This way you
> can just use rq->q->hardsect_size << 9 to get sectors_per_frame.

Yes that's precisely what I mean, there's no need to keep the same info
in several places.

--
Jens Axboe