From: Rusty Russell <rusty@rustcorp.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: "David S. Miller" <davem@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Simplify net/flow.c
Date: Fri, 23 Jan 2004 17:55:28 +1100 [thread overview]
Message-ID: <20040124050843.320902C056@lists.samba.org> (raw)
In-Reply-To: Your message of "Thu, 22 Jan 2004 19:51:04 -0800." <20040122195104.31cc2496.akpm@osdl.org>
In message <20040122195104.31cc2496.akpm@osdl.org> you write:
> It doesn't link if CONFIG_SMP=n. semaphore `cpucontrol', used in
> flow_cache_flush() is defined in kernel/cpu.c which is not included in
> uniprocessor builds.
>
> Here's one possible fix.
....
> /* Don't want cpus going down or up during this, also protects
> * against multiple callers. */
> - down(&cpucontrol);
> + down_cpucontrol();
OK. Although I think I prefer to have down_cpucontrol() defined under
#ifdef CONFIG_HOTPLUG_CPU, and revert to using a normal sem here as
well to cover the CONFIG_HOTPLUG_CPU=n CONFIG_SMP=y case. But I will
produce an additional patch with the hotplug cpu patches.
Thanks,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2004-01-24 5:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-22 7:49 [PATCH] Simplify net/flow.c Rusty Russell
2004-01-22 18:10 ` David S. Miller
2004-01-23 3:51 ` Andrew Morton
2004-01-23 6:55 ` Rusty Russell [this message]
2004-01-24 5:30 ` David S. Miller
2004-01-23 7:16 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040124050843.320902C056@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox