From: Tim Cambrant <tim@cambrant.com>
To: John Cherry <cherry@osdl.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
torvalds@osdl.org
Subject: [PATCH] Re: IA32 (2.6.2-rc1 - 2004-01-23.22.30) - 2 New warnings (gcc 3.2.2)
Date: Sat, 24 Jan 2004 13:01:13 +0100 [thread overview]
Message-ID: <20040124120113.GA26460@cambrant.com> (raw)
In-Reply-To: <200401241113.i0OBDnfH017530@cherrypit.pdx.osdl.net>
On Sat, Jan 24, 2004 at 03:13:49AM -0800, John Cherry wrote:
> fs/xfs/xfs_log_recover.c:1534: warning: `flags' might be used uninitialized in this function
This patch will initialize the ushort 'flags'. This is _really_ trivial, and
isn't needed, but if it's important to remove as many warnings as possible,
then this patch will sort it out.
--- linux-2.6.2-rc/fs/xfs/xfs_log_recover.c.orig Sat Jan 24 12:49:07 2004
+++ linux-2.6.2-rc/fs/xfs/xfs_log_recover.c Sat Jan 24 12:51:38 2004
@@ -1531,7 +1531,7 @@ xlog_recover_reorder_trans(
xlog_recover_item_t *first_item, *itemq, *itemq_next;
xfs_buf_log_format_t *buf_f;
xfs_buf_log_format_v1_t *obuf_f;
- ushort flags;
+ ushort flags = 0;
first_item = itemq = trans->r_itemq;
trans->r_itemq = NULL;
Apply this if it's really needed. GCC 3.4 doesn't give any warnings though.
Tim Cambrant
prev parent reply other threads:[~2004-01-24 12:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-24 11:13 IA32 (2.6.2-rc1 - 2004-01-23.22.30) - 2 New warnings (gcc 3.2.2) John Cherry
2004-01-24 12:01 ` Tim Cambrant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040124120113.GA26460@cambrant.com \
--to=tim@cambrant.com \
--cc=cherry@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox