From: Philippe Elie <phil.el@wanadoo.fr>
To: Andrew Morton <akpm@osdl.org>
Cc: Richard Henderson <rth@twiddle.net>,
John Levon <levon@movementarian.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] oprofile, typo in alpha driver
Date: Mon, 26 Jan 2004 03:01:35 +0000 [thread overview]
Message-ID: <20040126030135.GA3202@zaniah> (raw)
Unless I miss something this look like a typo, one user reported to get error
from the daemon: 'Unknown event for counter 1' (alpha ev6) and the behavior
was better but not completly sane after trying this patch: he get spurious
event for counter 1 when enabling only counter 0 but rarely now. No alpha box
to test this.
regards,
Phil
Index: arch/alpha/oprofile/common.c
===================================================================
RCS file: /usr/local/cvsroot/linux-2.5/arch/alpha/oprofile/common.c,v
retrieving revision 1.5
diff -u -p -r1.5 common.c
--- arch/alpha/oprofile/common.c 21 Jun 2003 16:20:31 -0000 1.5
+++ arch/alpha/oprofile/common.c 26 Jan 2004 02:43:38 -0000
@@ -57,7 +57,7 @@ op_axp_setup(void)
/* Compute the mask of enabled counters. */
for (i = e = 0; i < model->num_counters; ++i)
- if (ctr[0].enabled)
+ if (ctr[i].enabled)
e |= 1 << i;
reg.enable = e;
reply other threads:[~2004-01-26 1:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040126030135.GA3202@zaniah \
--to=phil.el@wanadoo.fr \
--cc=akpm@osdl.org \
--cc=levon@movementarian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox