public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] oprofile, typo in alpha driver
@ 2004-01-26  3:01 Philippe Elie
  0 siblings, 0 replies; only message in thread
From: Philippe Elie @ 2004-01-26  3:01 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Richard Henderson, John Levon, linux-kernel

Unless I miss something this look like a typo, one user reported to get error
from the daemon: 'Unknown event for counter 1' (alpha ev6) and the behavior
was better but not completly sane after trying this patch: he get spurious
event for counter 1 when enabling only counter 0 but rarely now. No alpha box
to test this.

regards,
Phil

Index: arch/alpha/oprofile/common.c
===================================================================
RCS file: /usr/local/cvsroot/linux-2.5/arch/alpha/oprofile/common.c,v
retrieving revision 1.5
diff -u -p -r1.5 common.c
--- arch/alpha/oprofile/common.c	21 Jun 2003 16:20:31 -0000	1.5
+++ arch/alpha/oprofile/common.c	26 Jan 2004 02:43:38 -0000
@@ -57,7 +57,7 @@ op_axp_setup(void)
 
 	/* Compute the mask of enabled counters.  */
 	for (i = e = 0; i < model->num_counters; ++i)
-		if (ctr[0].enabled)
+		if (ctr[i].enabled)
 			e |= 1 << i;
 	reg.enable = e;
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-01-26  1:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-26  3:01 [PATCH] oprofile, typo in alpha driver Philippe Elie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox