* Suspicious pointer usage in kobil_sct driver.
@ 2004-01-23 6:35 davej
2004-01-23 20:41 ` Greg KH
2004-01-27 0:42 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: davej @ 2004-01-23 6:35 UTC (permalink / raw)
To: linux-kernel; +Cc: greg
Greg, is this what's intended here?
Dave
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/usb/serial/kobil_sct.c linux-2.5/drivers/usb/serial/kobil_sct.c
--- bk-linus/drivers/usb/serial/kobil_sct.c 2003-09-29 20:00:01.000000000 +0100
+++ linux-2.5/drivers/usb/serial/kobil_sct.c 2004-01-23 05:06:40.000000000 +0000
@@ -651,7 +651,7 @@ static int kobil_ioctl(struct usb_seria
return 0;
case TCSETS: // 0x5402
- if (! &port->tty->termios) {
+ if (!(port->tty->termios)) {
dbg("%s - port %d Error: port->tty->termios is NULL", __FUNCTION__, port->number);
return -ENOTTY;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Suspicious pointer usage in kobil_sct driver.
2004-01-23 6:35 Suspicious pointer usage in kobil_sct driver davej
@ 2004-01-23 20:41 ` Greg KH
2004-01-27 0:42 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2004-01-23 20:41 UTC (permalink / raw)
To: davej; +Cc: linux-kernel
On Fri, Jan 23, 2004 at 06:35:25AM +0000, davej@redhat.com wrote:
> Greg, is this what's intended here?
Yes, your patch is correct. I'll go apply it, thanks.
greg k-h
> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/usb/serial/kobil_sct.c linux-2.5/drivers/usb/serial/kobil_sct.c
> --- bk-linus/drivers/usb/serial/kobil_sct.c 2003-09-29 20:00:01.000000000 +0100
> +++ linux-2.5/drivers/usb/serial/kobil_sct.c 2004-01-23 05:06:40.000000000 +0000
> @@ -651,7 +651,7 @@ static int kobil_ioctl(struct usb_seria
> return 0;
>
> case TCSETS: // 0x5402
> - if (! &port->tty->termios) {
> + if (!(port->tty->termios)) {
> dbg("%s - port %d Error: port->tty->termios is NULL", __FUNCTION__, port->number);
> return -ENOTTY;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Suspicious pointer usage in kobil_sct driver.
2004-01-23 6:35 Suspicious pointer usage in kobil_sct driver davej
2004-01-23 20:41 ` Greg KH
@ 2004-01-27 0:42 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2004-01-27 0:42 UTC (permalink / raw)
To: davej; +Cc: linux-kernel
On Fri, Jan 23, 2004 at 06:35:25AM +0000, davej@redhat.com wrote:
> Greg, is this what's intended here?
Applied, thanks.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-01-27 0:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-23 6:35 Suspicious pointer usage in kobil_sct driver davej
2004-01-23 20:41 ` Greg KH
2004-01-27 0:42 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox