public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: jim.houston@comcast.net
Cc: akpm@osdl.org, george@mvista.com, amitkale@emsyssoft.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kgdb-x86_64-support.patch for 2.6.2-rc1-mm3
Date: Tue, 27 Jan 2004 19:02:51 +0100	[thread overview]
Message-ID: <20040127190251.4edb873d.ak@suse.de> (raw)
In-Reply-To: <1075225399.1020.239.camel@new.localdomain>

On 27 Jan 2004 12:43:20 -0500
Jim Houston <jim.houston@comcast.net> wrote:

.
> 
> It looks like we were working in lock step.  I had been meaning to
> update the patch so when I saw that Andrew had dropped it from 
> 2.6.2-rc1-mm3 it seemed like a good time.
> 
> I'll leave it to you and Andrew to decide how we should resolve our
> conflicting patches.

If yours works on ethernet please use yours. Mine didn't.


> arch/x86_64/Kconfig
> arch/x86_64/Kconfig.kgdb
> 	We used a different approach to selecting DEBUG_INFO.
> 	I was not really happy with the way select DEBUG_INFO worked.

You reverted it back? 

What I did was to change all not really kgdb specific CONFIG_KGDB uses in
the main kernel with CONFIG_DEBUG_INFO (mostly CFI support). I don't feel
strongly about it, but this way there is no reference to an unknown
config symbol in mainline. Also DEBUG_INFO including CFI makes sense I think.

Putting the kgdb options into a separate sourced file is a good idea. 
This should decrease future conflicts.

> include/asm-x86_64/kgdb_local.h
> 	This file seems to be missing from your patch.  Maybe I'm 
> 	missing something.  In my patch it is a copy of the i386
> 	version.

Probably my fault.

-Andi 

  reply	other threads:[~2004-01-27 18:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20040127030529.8F860C60FC@h00e098094f32.ne.client2.attbi.com>
2004-01-27  3:28 ` [PATCH] kgdb-x86_64-support.patch for 2.6.2-rc1-mm3 Andrew Morton
2004-01-27 13:58   ` Jim Houston
2004-01-27 14:56 ` Andi Kleen
2004-01-27 17:43   ` Jim Houston
2004-01-27 18:02     ` Andi Kleen [this message]
2004-01-27 19:35       ` Jim Houston
2004-01-27 19:43         ` Andi Kleen
2004-01-27 20:37         ` George Anzinger
2004-01-27 20:54           ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040127190251.4edb873d.ak@suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=amitkale@emsyssoft.com \
    --cc=george@mvista.com \
    --cc=jim.houston@comcast.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox