From: Frodo Looijaard <frodol@dds.nl>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org
Subject: Re: PATCH to access old-style FAT fs
Date: Wed, 28 Jan 2004 12:56:55 +0100 [thread overview]
Message-ID: <20040128115655.GA696@arda.frodo.local> (raw)
In-Reply-To: <87ad4987ti.fsf@devron.myhome.or.jp>
On Wed, Jan 28, 2004 at 05:17:45AM +0900, OGAWA Hirofumi wrote:
> "H. Peter Anvin" <hpa@zytor.com> writes:
>
> > I guess the original poster has found filesystems which have a 0
> > followed by garbage.
Exactly. At least on those EPOC filesystems, and I seem to have had a
old diskette around (perhaps out of the DR-DOS age?) which had the same
problem. Regrettably, the diskette got hosed.
> The new cluster for directory entries must be initialized by 0x00.
> This is required by spec.
Might be. In that case the EPOC filesystems do not conform to spec. Now
that would be a first time.
> If cluster has garbage, the fat driver needs to do such the following
> part. Stop at DIR_Name[0] == 0 is not enough, and I don't think DOS
> does this.
[Patch fragment to set DIR_Name[0] to 0 when new dir entries are added]
I don't know. I do not have a working MS-DOS partition anymore to test
this on.
As I said, I *think* it is safe to have my patch always applied (that
is, stop when DIR_Name[0] == 0, and be careful to add a new DIR_Name[0] = 0
entry when new entries are added at the back). It would conform to the
standard. But I would not really be surprised if there was yet another
FAT implementation somewhere out there that breaks the standard in some
other subtle way, which works now but exhibits problems with my patch.
That is why I made it a mount option.
Thanks,
Frodo
--
Frodo Looijaard <frodol@dds.nl> PGP key and more: http://huizen.dds.nl/~frodol
Defenestration n. (formal or joc.):
The act of removing Windows from your computer in disgust, usually followed
by the installation of Linux or some other Unix-like operating system.
next prev parent reply other threads:[~2004-01-28 11:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-26 17:39 PATCH to access old-style FAT fs Frodo Looijaard
2004-01-26 19:38 ` H. Peter Anvin
2004-01-27 12:55 ` OGAWA Hirofumi
2004-01-27 18:51 ` H. Peter Anvin
2004-01-27 20:17 ` OGAWA Hirofumi
2004-01-28 11:56 ` Frodo Looijaard [this message]
2004-01-28 20:08 ` OGAWA Hirofumi
2004-01-28 20:24 ` Frodo Looijaard
2004-01-28 21:01 ` OGAWA Hirofumi
2004-01-29 10:56 ` Frodo Looijaard
2004-01-31 2:19 ` H. Peter Anvin
2004-01-31 17:19 ` OGAWA Hirofumi
2004-01-29 22:39 ` Frodo Looijaard
2004-01-29 22:49 ` H. Peter Anvin
2004-01-30 0:30 ` Andries Brouwer
2004-01-30 3:40 ` OGAWA Hirofumi
2004-02-01 14:51 ` Frodo Looijaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040128115655.GA696@arda.frodo.local \
--to=frodol@dds.nl \
--cc=hirofumi@mail.parknet.co.jp \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox