From: Greg KH <greg@kroah.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Hollis Blanchard <hollisb@us.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
francis.wiran@hp.com
Subject: Re: [PATCH] cpqarray update
Date: Wed, 28 Jan 2004 15:51:12 -0800 [thread overview]
Message-ID: <20040128235112.GC10906@kroah.com> (raw)
In-Reply-To: <40184960.7030207@pobox.com>
On Wed, Jan 28, 2004 at 06:44:32PM -0500, Jeff Garzik wrote:
> Jeff Garzik wrote:
> >Actually I disagree with GregKH on this.
> >
> >The register/unregister functions need to be returning error codes,
> >_not_ the count of interfaces registered. It is trivial to count the
> >registered interfaces in the driver itself, but IMO far more important
> >to propagate fatal errors back to the original caller.
>
> Nevermind, this got fixed. I'm still worried about the '1' return
> value, though, for zero controllers found.
Yeah, I don't really like it either, but figured it was a 2.7 task to
clean it up properly.
thanks,
greg k-h
next prev parent reply other threads:[~2004-01-28 23:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200401262002.i0QK2iAH031857@hera.kernel.org>
2004-01-26 20:15 ` [PATCH] cpqarray update Jeff Garzik
2004-01-28 15:46 ` Hollis Blanchard
2004-01-28 17:40 ` Greg KH
2004-01-28 23:39 ` Jeff Garzik
2004-01-28 23:44 ` Jeff Garzik
2004-01-28 23:51 ` Greg KH [this message]
2004-01-26 22:32 Wiran, Francis
2004-01-27 1:51 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2004-01-27 4:48 Wiran, Francis
2004-01-27 4:50 Wiran, Francis
2004-01-28 22:53 Wiran, Francis
2004-01-28 23:10 Wiran, Francis
2004-01-28 23:28 ` Greg KH
2004-01-29 16:39 Wiran, Francis
2004-01-29 16:56 ` Jeff Garzik
2004-01-29 19:20 Wiran, Francis
2004-01-29 20:14 ` Jeff Garzik
2004-01-30 16:22 Wiran, Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040128235112.GC10906@kroah.com \
--to=greg@kroah.com \
--cc=francis.wiran@hp.com \
--cc=hollisb@us.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox