public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Micha Feigin <michf@post.tau.ac.il>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Bart Samwel <bart@samwel.tk>
Subject: [patch] backport commit=NNN mount option for reiserfs to 2.4
Date: Thu, 29 Jan 2004 05:56:54 +0200	[thread overview]
Message-ID: <20040129035654.GA4052@luna.mooo.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]

I backported the commit=NNN mount option for reiserfs to 2.4 (the patch
is against 2.4.25-pre7).
This mount option allows to set the journal maximum age so that
reiserfs would play nicely with laptop-mode.
I did change the settings a bit so that setting commit=0 sets the
journals maximum age to the default value so that the value can be
switched between the default and a longer one when laptop-mode is
activated (since if I am not mistaken the current value can't be
extracted in user mode unless the reiserfs proc entry option is
compiled in and thus this can't be done at the script level).
This did take a bit of work since reiserfs stores this value on disk in
the journal header which isn't kept in memory later. Thus the value
needs to either be reread from disk when resetting to the default value
or stored in memory with the current value.
Each has its problems. I went with the first option since there seems
to be disk activity anyway during remount, and this is non-intrusive
on the current structures.
This is instead of the current implementation that ext3 uses for
laptop-mode (there is no such implementation for reiserfs in 2.4),
which after looking at the code may be a bit less intrusive but is more
of a hack (and it does tramp over the existing commit=NNN mount option
in ext3 BTW).
Any comments are welcome.

[-- Attachment #2: reiserfs-commit_max_age-mount_option-2.4.25.diff.bz2 --]
[-- Type: application/octet-stream, Size: 2256 bytes --]

                 reply	other threads:[~2004-01-29  3:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040129035654.GA4052@luna.mooo.com \
    --to=michf@post.tau.ac.il \
    --cc=bart@samwel.tk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox