public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matt Mackall <mpm@selenic.com>
To: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Lindent fixed to match reality
Date: Thu, 29 Jan 2004 15:46:21 -0600	[thread overview]
Message-ID: <20040129214621.GL21888@waste.org> (raw)
In-Reply-To: <20040129201556.GK16675@khan.acc.umu.se>

On Thu, Jan 29, 2004 at 09:15:56PM +0100, David Weinehall wrote:
> On Thu, Jan 29, 2004 at 01:37:28PM -0600, Matt Mackall wrote:
> > I've been fiddling with cleaning up some old code here and suggest the
> > following to make Lindent match actual practice more closely. This does:
> > 
> > a) (no -psl)
> > 
> > void *foo(void) {
> > 
> >  instead of
> > 
> > void *
> > foo(void) {
> > 
> > b) (no -bs) "sizeof(foo)" rather than "sizeof (foo)"
> 
> I can't really see the logic in this, though I know a lot of people do
> it.  I try to stay consistent, thus I do:
> 
> if ()
> for ()
> case ()
> while ()
> sizeof ()
> typeof ()

Well, sizeof and typeof are operators rather than flow structures so
they're a little different. But what I'm really trying to do here is
make Lindent match actual practice (as a first approximation of the
community's preferred practice) rather than argue the merits of any
particular usage.

-- 
Matt Mackall : http://www.selenic.com : Linux development and consulting

  parent reply	other threads:[~2004-01-29 21:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-29 19:37 Lindent fixed to match reality Matt Mackall
2004-01-29 19:44 ` Linus Torvalds
2004-01-29 20:00   ` Matt Mackall
2004-01-29 20:15 ` David Weinehall
2004-01-29 20:35   ` Måns Rullgård
2004-01-29 20:42     ` David Weinehall
2004-01-29 20:52       ` Måns Rullgård
2004-01-29 21:46   ` Matt Mackall [this message]
2004-01-29 22:37   ` Andries Brouwer
2004-01-29 22:54     ` David Weinehall
2004-01-29 23:17       ` Tim Hockin
2004-01-29 23:43         ` David Weinehall
2004-01-30 14:44           ` Theodore Ts'o
2004-01-30 17:49             ` David Weinehall
2004-01-30 21:08   ` Eric W. Biederman
2004-01-29 20:17 ` Roland Dreier
2004-01-29 20:37 ` Erik Hensema
2004-01-29 21:55   ` Krzysztof Halasa
2004-01-30 16:36     ` Linus Torvalds
2004-01-30 10:38   ` Jan-Benedict Glaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040129214621.GL21888@waste.org \
    --to=mpm@selenic.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox