public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: linux-kernel@vger.kernel.org
Subject: Re: Lindent fixed to match reality
Date: Fri, 30 Jan 2004 11:38:47 +0100	[thread overview]
Message-ID: <20040130103846.GR20536@lug-owl.de> (raw)
In-Reply-To: <slrnc1irnj.2is.erik@bender.home.hensema.net>

[-- Attachment #1: Type: text/plain, Size: 1562 bytes --]

On Thu, 2004-01-29 20:37:07 +0000, Erik Hensema <erik@hensema.net>
wrote in message <slrnc1irnj.2is.erik@bender.home.hensema.net>:
> Matt Mackall (mpm@selenic.com) wrote:

> You just nicely broke 'find . -name *.c | xargs grep ^foo'.

That's what I like, too:)

> Why make functions harder to find? It's just one line... Being
> able to navigate the source tree with standard unix utils is a
> Good Thing.
> 
> Even better, IMHO:
> 
> void *
> foo(void)

...which may even help you preparing header files' declarations if you
did a long shot of coding without adding the declarations in time!

> Yes, that takes a full three lines. But within the function body
> you can just reverse search for ^{ and you're at the function
> declaration. Not nearly as useful as grepping for a function
> name, but still a nice thing to have, IMHO.

It's quite useful!

> > b) (no -bs) "sizeof(foo)" rather than "sizeof (foo)"
> Agreed.

I prefer sizeof with a space, but that's pure religion...

> > c) (-ncs) "(void *)foo" rather than "(void *) foo"
> Agreed.

...as well as with casts.

That's all sooo much religion. Let's keep coding and not argue about
indention. Just keep *consistend* within a single file...

MfG, JBG

-- 
   Jan-Benedict Glaw       jbglaw@lug-owl.de    . +49-172-7608481
   "Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg
    fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!
   ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

      parent reply	other threads:[~2004-01-30 10:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-29 19:37 Lindent fixed to match reality Matt Mackall
2004-01-29 19:44 ` Linus Torvalds
2004-01-29 20:00   ` Matt Mackall
2004-01-29 20:15 ` David Weinehall
2004-01-29 20:35   ` Måns Rullgård
2004-01-29 20:42     ` David Weinehall
2004-01-29 20:52       ` Måns Rullgård
2004-01-29 21:46   ` Matt Mackall
2004-01-29 22:37   ` Andries Brouwer
2004-01-29 22:54     ` David Weinehall
2004-01-29 23:17       ` Tim Hockin
2004-01-29 23:43         ` David Weinehall
2004-01-30 14:44           ` Theodore Ts'o
2004-01-30 17:49             ` David Weinehall
2004-01-30 21:08   ` Eric W. Biederman
2004-01-29 20:17 ` Roland Dreier
2004-01-29 20:37 ` Erik Hensema
2004-01-29 21:55   ` Krzysztof Halasa
2004-01-30 16:36     ` Linus Torvalds
2004-01-30 10:38   ` Jan-Benedict Glaw [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040130103846.GR20536@lug-owl.de \
    --to=jbglaw@lug-owl.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox