public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, michael@mvdavid.com
Subject: Re: raid6 badness
Date: Sat, 31 Jan 2004 10:24:59 +0100	[thread overview]
Message-ID: <20040131102459.37b8929d.ak@suse.de> (raw)
In-Reply-To: <401B421F.4060104@zytor.com>

On Fri, 30 Jan 2004 21:50:23 -0800
"H. Peter Anvin" <hpa@zytor.com> wrote:

> Andi Kleen wrote:
> > "H. Peter Anvin" <hpa@zytor.com> writes:
> > 
> >>I don't know what would cause the stack to be misaligned, however.
> > 
> > x86-64 kernel doesn't guarantee the stack to be 16 byte aligned
> > (although it usually is). If you need 16 byte alignment you have 
> > to align yourself.
> > 
> 
> OK, that's unfortunate... per our discussion I really think this is a 
> bug, since the compiler still does 16-byte alignment, and thus we're 
> taking the cost without the benefit.

I disagree on the "bug" part. I will check with the compiler guys, but 
as long as gcc doesn't rely on 16 byte alignment I will rather just disable it 
in the compiler.

I don't see much sense in enforcing this just because of some obscure SSE2
function that can align itself. Saving instructions and stack space
would be more important.

-Andi

  reply	other threads:[~2004-01-31  9:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.58.0401301158340.8900@sapphire.newearth.org.suse.lists.linux.kernel>
     [not found] ` <bvf2vl$6pr$1@terminus.zytor.com.suse.lists.linux.kernel>
2004-01-31  3:04   ` raid6 badness Andi Kleen
2004-01-31  5:50     ` H. Peter Anvin
2004-01-31  9:24       ` Andi Kleen [this message]
2004-01-31 13:10       ` Michael V. David
2004-02-01  7:33         ` H. Peter Anvin
2004-01-30 17:15 Michael V. David
2004-01-31  2:13 ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040131102459.37b8929d.ak@suse.de \
    --to=ak@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@mvdavid.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox