public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <dan@debian.org>
To: Roland McGrath <roland@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.2-rc3 broke ptrace in the vsyscall dso area
Date: Mon, 2 Feb 2004 10:39:19 -0500	[thread overview]
Message-ID: <20040202153918.GA1935@nevyn.them.org> (raw)
In-Reply-To: <200402020543.i125hgoa009640@magilla.sf.frob.com>

On Sun, Feb 01, 2004 at 09:43:42PM -0800, Roland McGrath wrote:
> > Any idea what might have disabled this?
> 
> ...Mosberger!!  When Andrew asked me to sign off on David's rework of that
> code, I did so with the caveat that it be tested on i386 before being
> accepted, and evidently it never was.
> 
> The #include is the part of this patch that matters, so the #ifdef below
> works.  (Frankly, I have never seen the rationale for conditionalizing this
> code on AT_SYSINFO_EHDR rather than just FIXADDR_USER_START.  But David
> wanted it that way and Andrew approved it.)  The rest of the patch removes
> gratuitous duplication due to some strange aversion to concision in the
> presence of #ifdef, the kind that is all too common, utterly pointless, and
> error prone.

Thanks, adding <linux/elf.h> makes GDB much happier.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

      reply	other threads:[~2004-02-02 15:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-02  3:55 2.6.2-rc3 broke ptrace in the vsyscall dso area Daniel Jacobowitz
2004-02-02  5:43 ` Roland McGrath
2004-02-02 15:39   ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040202153918.GA1935@nevyn.them.org \
    --to=dan@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox