From: Greg KH <greg@kroah.com>
To: Dely Sy <dlsy@snoqualmie.dp.intel.com>
Cc: linux-kernel@vger.kernel.org,
pcihpd-discuss@lists.sourceforge.net, dely.l.sy@intel.com,
tony.luck@intel.com
Subject: Re: Patch to get cpqphp working with IOAPIC (2.6.0-test5)
Date: Mon, 2 Feb 2004 12:05:55 -0800 [thread overview]
Message-ID: <20040202200555.GA32087@kroah.com> (raw)
In-Reply-To: <200309161550.h8GFoO2X003176@snoqualmie.dp.intel.com>
On Tue, Sep 16, 2003 at 08:50:24AM -0700, Dely Sy wrote:
> Hi,
>
> Here is a patch for 2.6.0-test5 to get cpqphp working with IOAPIC.
> My earlier statement that a kernel patch is not needed for 2.6 is
> true only when ACPI is enabled. A similar patch is needed in
> pcibios_enable_irq() for 2.4 kernel and I will send it out
> later.
>
> The fix is in pirq_enable_irq(). This function is called indirectly
> by pci_enable_device(). For device present during boot up, it should
> get the proper dev->irq for pcibios_fixup_irqs() has been called to
> get the dev->irq from MP table. If the value is still zero, then
> this is properly caused by "buggy MP table". For hot-plug device,
> its dev->irq is 0 when the pci_enable_device() is called for it hasn't
> gone through the fixup. Therefore, the code (similiar to the code
> in pcibios_fixup_irqs) is needed here.
Wow, very sorry for the long delay here. I took the patch you sent me
for the irq.c file in your previous big SHPC patch and added it to the
rest of the cpqphp changes you made here, and applied it to my trees.
thanks,
greg k-h
prev parent reply other threads:[~2004-02-02 20:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-16 15:50 Patch to get cpqphp working with IOAPIC (2.6.0-test5) Dely Sy
2004-02-02 20:05 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040202200555.GA32087@kroah.com \
--to=greg@kroah.com \
--cc=dely.l.sy@intel.com \
--cc=dlsy@snoqualmie.dp.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pcihpd-discuss@lists.sourceforge.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox