Re: [PATCH 3/4] 2.6.2-rc2-mm2 CPU Hotplug: The Core

Srivatsa Vaddagiri
2004-02-02T13:19:03Z

On Mon, Feb 02, 2004 at 07:45:32AM -0500, Ingo Molnar wrote:
>
> On Mon, 2 Feb 2004, Rusty Russell wrote:
>
> > Unfortunately the __migrate_task() check won't go away: someone may have
> > asked to move from CPU 0 to 1, and by the time migration thread on 0
> > gets to the request, 1 has gone down. We don't want all the callers to
> > hold the cpucontrol lock, because now the NUMA scheduler uses migration
> > as a common case 8(
>
> well, when a CPU goes down it could process the migration request queue as
> well. (this would be a pretty natural thing to do if CPU-down executes in
> the migration-thread context.)

One possibility is the migration request will be in
CPU 0's queue and not in CPU1's? Hence there won't be anything (in
CPU1's migration request queue) to process when CPU1 is brought down.
However by the time migration thread on CPU 0 gets around to processing the
request, CPU1 is already down and hence the check.

--

Thanks and Regards,
Srivatsa Vaddagiri,
Linux Technology Center,
IBM Software Labs,
Bangalore, INDIA - 560017