From: Ingo Molnar <mingo@elte.hu>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Srivatsa Vaddagiri <vatsa@in.ibm.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org,
Nick Piggin <piggin@cyberone.com.au>,
dipankar@in.ibm.com
Subject: Re: New v. v. experimental HOTPLUG CPU megapatch.
Date: Tue, 3 Feb 2004 10:35:02 +0100 [thread overview]
Message-ID: <20040203093502.GA4399@elte.hu> (raw)
In-Reply-To: <20040203074322.27A892C13E@lists.samba.org>
* Rusty Russell <rusty@rustcorp.com.au> wrote:
> Patch against 2.6.2-rc2-mm2. Works basically, gives "APIC error on
> CPU1: 08(08)" under stress. Clues welcome.
APIC error 08 is receive error. Ie. most likely there was a pending IPI
(or pending hwirq) to that CPU but the CPU was zapped and the APIC
reset. I'd suggest to add "sti;nop;cli" instructions after the IO-APIC
masks have been redirected [note the nop - the interrupt-enable boundary
on x86 is two instructions from sti] - to flush out pending hardirqs and
IPIs. After this point nothing is supposed to reach this CPU. Enabling
irqs at this point should not cause any races, because you do this
first, right?
the pending cross-CPU-IPI case should not happen if the infrastructure
is correct, external hardirqs are not an issue unless it's an
edge-triggered device. So the worst-case with your current code could be
a lost timer IRQ or a lost edge-triggered PCI irq (old ne2k cards).
Ingo
next prev parent reply other threads:[~2004-02-03 10:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-31 14:16 [PATCH 3/4] 2.6.2-rc2-mm2 CPU Hotplug: The Core Rusty Russell
2004-02-01 8:03 ` Andrew Morton
2004-02-01 10:19 ` Nick Piggin
2004-02-01 12:07 ` Rusty Russell
2004-02-02 9:12 ` Ingo Molnar
2004-02-02 10:55 ` Rusty Russell
2004-02-02 12:45 ` Ingo Molnar
2004-02-02 13:22 ` Srivatsa Vaddagiri
2004-02-02 15:40 ` Ingo Molnar
2004-02-03 0:45 ` Rusty Russell
2004-02-03 8:04 ` Ingo Molnar
2004-02-03 8:16 ` Rusty Russell
2004-02-03 8:31 ` Ingo Molnar
2004-02-03 7:39 ` New v. v. experimental HOTPLUG CPU megapatch Rusty Russell
2004-02-03 9:35 ` Ingo Molnar [this message]
2004-02-05 18:12 ` Pavel Machek
2004-02-03 0:34 ` [PATCH 3/4] 2.6.2-rc2-mm2 CPU Hotplug: The Core Rusty Russell
2004-02-03 9:26 ` Ingo Molnar
2004-02-04 0:19 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040203093502.GA4399@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=piggin@cyberone.com.au \
--cc=rusty@rustcorp.com.au \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox