Re: [PATCH 3/4] 2.6.2-rc2-mm2 CPU Hotplug: The Core

Nick Piggin
2004-02-01T10:20:14Z

Andrew Morton wrote:

>Rusty Russell <rusty@rustcorp.com.au> wrote:
>
>> The actual CPU patch. It's big, but almost all under
>> CONFIG_HOTPLUG_CPU, or macros which have same effect.
>>
>
>Needs a fixup.
>
>
>
>CPU_MASK_ALL and CPU_MASK_NONE may only be used for initialisers. It
>doesn't compile if NR_CPUS>4*BITS_PER_LONG. Fixes to the cpumask
>infrastructure for this remain welcome.
>
>

The kernel/sched.c stuff otherwise looks pretty straightforward
at a quick glance. I can't see any fundamental problem with it.