public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: John Rose <johnrose@austin.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [Bug 2013] New: Oops from create_dir (sysfs)
Date: Wed, 4 Feb 2004 14:00:16 -0800	[thread overview]
Message-ID: <20040204220016.GD3897@kroah.com> (raw)
In-Reply-To: <1075931022.3026.63.camel@verve>

On Wed, Feb 04, 2004 at 03:43:42PM -0600, John Rose wrote:
> <crickets chirp>.  That's one way to shut me up :)

Honestly, I like the way this currently works.  You tried to do
something not allowed, and the kernel dies.  Now it would be nice to be
able to provide a better type of error message to help the unsuspecting
developer out, but that's just fluff :)

> In all seriousness, how much of a performance problem would be posed by
> throwing a kset_find_obj() check somewhere in the beginning of
> kobject_add()? 

Why not just fix the sysfs create_dir() function to not oops and report
back the proper error message in this case?

thanks,

greg k-h

  reply	other threads:[~2004-02-04 22:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-04 20:27 [Bug 2013] New: Oops from create_dir (sysfs) John Rose
2004-02-04 20:48 ` Greg KH
2004-02-04 20:54   ` John Rose
2004-02-04 21:22     ` Greg KH
2004-02-04 21:43       ` John Rose
2004-02-04 22:00         ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-02-04 18:55 Martin J. Bligh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040204220016.GD3897@kroah.com \
    --to=greg@kroah.com \
    --cc=johnrose@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox