From: a.othieno@bluewin.ch (Arthur Othieno)
To: Bryan Whitehead <driver@megahappy.net>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.2] Documentation/SubmittingPatches
Date: Thu, 5 Feb 2004 20:05:26 +0100 [thread overview]
Message-ID: <20040205190526.GA25392@mars> (raw)
In-Reply-To: <20040205072303.BCF79FA5F1@mrhankey.megahappy.net>
On Wed, Feb 04, 2004 at 11:23:03PM -0800, Bryan Whitehead wrote:
>
> I've been trying to get my feet wet by submitting trivial patchs to
> various maintainers and the responses have been, "your not submiting
> you patches correctly". It seems most developers/maintainers want a
> diff done like this:
>
> cd /source-tree
> diff -u linux-2.6.2/FileToPatch.orig linux-2.6.2/FileToPatch
>
> instead of the "SubmitingPatches" document way:
> cd /source-tree/linux-2.6.2
> diff -u FileToPatch.orig FileToPatch
>
> It would be _great_ if the Documentation was more accurate to the taste
> of developers/maintainers...
>
> If the SubmittingPatches document is correct, then just toss this patch
> out because this won't be submitted right... ;)
>
> --- linux-2.6.2/Documentation/SubmittingPatches.orig 2004-02-04 22:57:55.818563016 -0800
> +++ linux-2.6.2/Documentation/SubmittingPatches 2004-02-04 23:01:28.799185040 -0800
> @@ -33,13 +33,15 @@
>
> To create a patch for a single file, it is often sufficient to do:
>
> - SRCTREE= /devel/linux-2.4
> + SRCTREE= /devel/
> + SRCDIR= linux-2.4
> MYFILE= drivers/net/mydriver.c
Might as well change this to `linux-2.6' altogether.
Arthur
next prev parent reply other threads:[~2004-02-05 19:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-05 7:23 [PATCH 2.6.2] Documentation/SubmittingPatches Bryan Whitehead
2004-02-05 8:18 ` Riley Williams
2004-02-05 19:05 ` Arthur Othieno [this message]
2004-02-06 3:45 ` jw schultz
2004-02-06 4:13 ` Randy.Dunlap
2004-02-06 17:23 ` Tim Bird
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040205190526.GA25392@mars \
--to=a.othieno@bluewin.ch \
--cc=driver@megahappy.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox