From: Adrian Bunk <bunk@fs.tum.de>
To: John Cherry <cherry@osdl.org>,
"Zephaniah E. Hull" <warp@mercury.d2dc.net>
Cc: Andrew Morton <akpm@osdl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
vojtech@suse.cz, gregkh@us.ibm.com
Subject: [patch] 2.6.2-mm1: fix warning introduced by input-2wheel-mouse-fix
Date: Fri, 6 Feb 2004 00:12:27 +0100 [thread overview]
Message-ID: <20040205231226.GC26093@fs.tum.de> (raw)
In-Reply-To: <1076003898.12450.15.camel@cherrytest.pdx.osdl.net>
On Thu, Feb 05, 2004 at 09:58:18AM -0800, John Cherry wrote:
>...
> The nit warnings that sprung up in the defconfig builds are...
>...
> drivers/usb/input/hid-input.c: In function `hidinput_hid_event':
> drivers/usb/input/hid-input.c:436: warning: suggest parentheses around
> && within ||
>...
This one's easy to fix:
--- linux-2.6.2-mm1/drivers/usb/input/hid-input.c.old 2004-02-06 00:05:19.000000000 +0100
+++ linux-2.6.2-mm1/drivers/usb/input/hid-input.c 2004-02-06 00:05:50.000000000 +0100
@@ -433,7 +433,7 @@
input_regs(input, regs);
if (((hid->quirks & HID_QUIRK_2WHEEL_MOUSE_HACK_EXTRA) && (usage->code == BTN_EXTRA))
- || (hid->quirks & HID_QUIRK_2WHEEL_MOUSE_HACK_BACK) && (usage->code == BTN_BACK)) {
+ || ((hid->quirks & HID_QUIRK_2WHEEL_MOUSE_HACK_BACK) && (usage->code == BTN_BACK))) {
if (value)
hid->quirks |= HID_QUIRK_2WHEEL_MOUSE_HACK_ON;
else
Please apply
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2004-02-05 23:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-05 9:44 2.6.2-mm1 aka "Geriatric Wombat" Andrew Morton
2004-02-05 9:52 ` [PATCH] via crypto beginnings Jeff Garzik
2004-02-05 10:11 ` Andrew Morton
2004-02-05 9:55 ` 2.6.2-mm1 aka "Geriatric Wombat" Nikita Danilov
2004-02-05 10:00 ` Russell King
2004-02-05 10:37 ` Jeff Garzik
2004-02-05 10:50 ` Russell King
2004-02-05 11:47 ` Nick Piggin
2004-02-05 16:11 ` Martin J. Bligh
2004-02-05 16:16 ` Nick Piggin
2004-02-05 16:20 ` Nikita Danilov
2004-02-05 13:57 ` Alistair John Strachan
2004-02-05 14:16 ` Lenar Lõhmus
2004-02-05 19:57 ` 2.6.2-mm1 [are these mine?] Maciej Soltysiak
2004-02-05 20:11 ` Randy.Dunlap
2004-02-05 20:14 ` Randy.Dunlap
2004-02-05 21:30 ` 2.6.2-mm1 aka "Geriatric Wombat" Alistair John Strachan
2004-02-06 8:39 ` Lenar Lõhmus
2004-02-05 14:16 ` Matthias Urlichs
2004-02-05 17:58 ` John Cherry
2004-02-05 23:12 ` Adrian Bunk [this message]
2004-02-06 0:22 ` [patch] 2.6.2-mm1: fix warning introduced by input-2wheel-mouse-fix Zephaniah E. Hull
2004-02-05 19:23 ` 2.6.2-mm1 aka "Geriatric Wombat" Deepak Saxena
2004-02-05 20:05 ` Greg KH
2004-02-05 23:31 ` 2.6.2-mm1 aka "Geriatric Wombat" DIO read race still fails Daniel McNeil
2004-02-05 23:58 ` Badari Pulavarty
2004-02-06 22:37 ` Daniel McNeil
2004-02-06 0:07 ` Andrew Morton
2004-02-06 0:32 ` Daniel McNeil
2004-02-06 18:02 ` 2.6.2-mm1 aka "Geriatric Wombat" Thomas Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040205231226.GC26093@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=akpm@osdl.org \
--cc=cherry@osdl.org \
--cc=gregkh@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
--cc=warp@mercury.d2dc.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox