From: Greg KH <greg@kroah.com>
To: James Simmons <jsimmons@infradead.org>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: fbdev sysfs support.
Date: Fri, 6 Feb 2004 17:23:13 -0800 [thread overview]
Message-ID: <20040207012313.GF4492@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0402070100420.19559-100000@phoenix.infradead.org>
On Sat, Feb 07, 2004 at 01:01:35AM +0000, James Simmons wrote:
> +static ssize_t show_dev(struct class_device *class_dev, char *buf)
> +{
> + struct fb_info *info = to_fb_info(class_dev);
> +
> + return sprintf(buf, "%u:%u\n", FB_MAJOR, info->node);
> +}
Another ick. Please use the already present function for this,
print_dev_t().
thanks,
greg k-h
prev parent reply other threads:[~2004-02-07 1:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-07 0:34 fbdev sysfs support James Simmons
2004-02-07 0:59 ` Greg KH
2004-02-07 1:01 ` James Simmons
2004-02-07 1:10 ` viro
2004-02-07 1:19 ` Greg KH
2004-02-07 1:22 ` viro
2004-02-07 1:23 ` James Simmons
2004-02-07 1:28 ` Greg KH
2004-02-07 1:31 ` viro
2004-02-07 1:29 ` viro
2004-02-07 1:15 ` Greg KH
2004-02-07 1:24 ` viro
2004-02-07 1:23 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040207012313.GF4492@kroah.com \
--to=greg@kroah.com \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox