Re: fbdev sysfs support.

viro
2004-02-07T01:32:13Z

On Sat, Feb 07, 2004 at 01:23:29AM +0000, James Simmons wrote:
>
> > This function will not get called until the sysfs node stops being busy,
> > so it should all work properly. But only if that fb_info structure was
> > allocated dynamically, unlike all of the current fb drivers (see my
> > other comment about this patch.)
> >
> > So in that case, this will cause us to try to call kfree on a static
> > structure :(
>
> I plan to move every driver to framebuffer_alloc.

Erm... You know, it would be much better to do that _before_ sysfs-related
merge. With framebuffer_release() being originally defined as kfree(),
so that no breakage would happen during the transition. Once everything is
using dynamic allocation with framebuffer_alloc()/framebuffer_free(), add
sysfs bits. That way you get the same total size of patches in the series
and avoid the breakage on intermediate stages...