public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Frank <mhf@linuxmail.org>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: riel@redhat.com, axboe@suse.de, marcelo.tosatti@cyclades.com,
	linux-kernel@vger.kernel.org
Subject: Re: 2.4.25-rc1: BUG: wrong zone alignment, it will crash
Date: Sat, 7 Feb 2004 02:35:23 +0800	[thread overview]
Message-ID: <200402070235.23546.mhf@linuxmail.org> (raw)
In-Reply-To: <20040206090717.5e4f25e2.rddunlap@osdl.org>

On Saturday 07 February 2004 01:07, Randy.Dunlap wrote:
> On Sat, 7 Feb 2004 00:46:31 +0800 Michael Frank <mhf@linuxmail.org> wrote:
> 
> | On Friday 06 February 2004 23:36, Rik van Riel wrote:
> | > On Fri, 6 Feb 2004, Michael Frank wrote:
> | > 
> | > > > > 300MB HIGHMEM available.
> | > > > > 195MB LOWMEM available.
> | > > > > On node 0 totalpages: 126960
> | > > > > zone(0): 4096 pages.
> | > > > > zone(1): 46064 pages.
> | > > > > zone(2): 76800 pages.
> | > > > > BUG: wrong zone alignment, it will crash
> | > 
> | > > It is supposed to work, just a bug in the zone alignment code.
> | > 
> | > The error isn't in the kernel, it's between the chair and the keyboard.
> | > You have created a lowmem zone of a size that doesn't correctly
> | > align with the largest blocks used by the buddy allocator.
> | > 
> | > > I have have to use HIGHMEM emulation for testing.
> | > 
> | > Then you'll need to choose a different size for the highmem=
> | > parameter, one that doesn't cause an unaligned boundary.
> | 
> | Which is not user friendly and does not match the documentation.
> 
> Interesting boot option...  but what doc. are you referring to?

Line 863 of 2.4.2[45]/arch/i386/setup.c

/*
 * highmem=size forces highmem to be exactly 'size' bytes.
 * This works even on boxes that have no highmem otherwise.
 * This also works to reduce highmem size on bigger boxes.
 */
else if (!memcmp(from, "highmem=", 8))
	highmem_pages = memparse(from+8, &from) >> PAGE_SHIFT;

> 
> 
> | > Alternatively, you could submit a patch so the highmem= boot
> | > option parsing code does the aligning for you.
> | 
> | OK, will do. I'll produce and test a patch.
> 
> Please include an update to Documentation/kernel-parameters.txt .

Sure.

> 
> | > However, that would simply be an improvement to the kernel and
> | > nothing like a bug you can demand to get fixed now.
> | 
> | OK, Please note that I only passed on the message produced by the kernel 
> |   BUG: wrong zone alignment, it will crash 
> | 
> | Perhaps the kernel should have reported it as "Invalid value for highmem" 
> | instead of "BUG" ;)
> 
> How does this option work?  Does it just fake highmem_pages of
> low memory as being in high memory?

Sort of, it maps some pages into highmem zone instead of lowmem zone.

Regards
Michael


      reply	other threads:[~2004-02-06 18:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-06 10:34 2.4.25-rc1: BUG: wrong zone alignment, it will crash Michael Frank
2004-02-06 13:44 ` Marcelo Tosatti
2004-02-06 14:45   ` Michael Frank
2004-02-06 15:36     ` Rik van Riel
2004-02-06 16:46       ` Michael Frank
2004-02-06 17:07         ` Randy.Dunlap
2004-02-06 18:35           ` Michael Frank [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200402070235.23546.mhf@linuxmail.org \
    --to=mhf@linuxmail.org \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=rddunlap@osdl.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox