From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263600AbUBHNOV (ORCPT ); Sun, 8 Feb 2004 08:14:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263606AbUBHNOV (ORCPT ); Sun, 8 Feb 2004 08:14:21 -0500 Received: from hermes.fachschaften.tu-muenchen.de ([129.187.202.12]:35047 "HELO hermes.fachschaften.tu-muenchen.de") by vger.kernel.org with SMTP id S263600AbUBHNOU (ORCPT ); Sun, 8 Feb 2004 08:14:20 -0500 Date: Sun, 8 Feb 2004 14:14:14 +0100 From: Adrian Bunk To: Andrew Morton Cc: jgarzik@pobox.com, linux@syskonnect.de, linux-kernel@vger.kernel.org Subject: Re: 2.6.1-rc1-mm2: warning in drivers/net/sk98lin/skge.c Message-ID: <20040208131413.GP7388@fs.tum.de> References: <20040105002056.43f423b1.akpm@osdl.org> <20040106181318.GH11523@fs.tum.de> <20040106102009.4e058f51.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040106102009.4e058f51.akpm@osdl.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 06, 2004 at 10:20:09AM -0800, Andrew Morton wrote: > Adrian Bunk wrote: > > > > drivers/net/sk98lin/skge.c: In function `skge_probe': > > drivers/net/sk98lin/skge.c:713: warning: unused variable `proc_root_initialized' > > hm, I thought I sent Jeff a fix for that. > > Yes, the definition should just be deleted. This warning is still present in 2.6.2-mm1 and 2.6.3-rc1. Please apply the following patch: --- linux-2.6.2-mm1/drivers/net/sk98lin/skge.c.old 2004-02-08 14:11:48.000000000 +0100 +++ linux-2.6.2-mm1/drivers/net/sk98lin/skge.c 2004-02-08 14:11:57.000000000 +0100 @@ -294,7 +294,6 @@ SK_BOOL BootStringCount = SK_FALSE; int retval; #ifdef CONFIG_PROC_FS - int proc_root_initialized = 0; struct proc_dir_entry *pProcFile; #endif cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed