From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265912AbUBJOtQ (ORCPT ); Tue, 10 Feb 2004 09:49:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265915AbUBJOtP (ORCPT ); Tue, 10 Feb 2004 09:49:15 -0500 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:43783 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S265912AbUBJOsq (ORCPT ); Tue, 10 Feb 2004 09:48:46 -0500 Date: Tue, 10 Feb 2004 14:47:19 +0000 From: Russell King To: Geert Uytterhoeven Cc: Linus Torvalds , Greg Kroah-Hartman , Kernel Mailing List Subject: Re: dmapool (was: Re: Linux 2.6.3-rc2) Message-ID: <20040210144719.B23310@flint.arm.linux.org.uk> Mail-Followup-To: Geert Uytterhoeven , Linus Torvalds , Greg Kroah-Hartman , Kernel Mailing List References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from geert@linux-m68k.org on Tue, Feb 10, 2004 at 03:32:47PM +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 10, 2004 at 03:32:47PM +0100, Geert Uytterhoeven wrote: > On Tue, 10 Feb 2004, Geert Uytterhoeven wrote: > > The dmapool code makes dma_{alloc,free}_coherent() a requirement for all > > platforms, breaking platforms that don't have it (e.g. m68k, and from a quick > > browse sparc and sparc64 probably, too). > > > > May not be that nice for a release candidate in a stable series... > > This patch seems to fix the problem (all offending platforms include > if CONFIG_PCI only): Please don't - that breaks ARM. Part of the whole point of dmapool is that it provides a generic DMA pool implementation, especially for non-PCI USB devices. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core