From: Joe Thornber <thornber@redhat.com>
To: Joe Thornber <thornber@redhat.com>
Cc: Linux Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: [Patch 3/10] dm: Get rid of struct dm_deferred_io in dm.c
Date: Tue, 10 Feb 2004 16:59:33 +0000 [thread overview]
Message-ID: <20040210165933.GI27507@reti> (raw)
In-Reply-To: <20040210163548.GC27507@reti>
Get rid of struct dm_deferred_io in dm.c. [Chripstophe Saout]
--- diff/drivers/md/dm.c 2004-02-10 16:11:24.000000000 +0000
+++ source/drivers/md/dm.c 2004-02-10 16:11:30.000000000 +0000
@@ -27,11 +27,6 @@
atomic_t io_count;
};
-struct deferred_io {
- struct bio *bio;
- struct deferred_io *next;
-};
-
/*
* Bits for the md->flags field.
*/
@@ -52,7 +47,7 @@
*/
atomic_t pending;
wait_queue_head_t wait;
- struct deferred_io *deferred;
+ struct bio *deferred;
/*
* The current mapping.
@@ -188,38 +183,20 @@
mempool_free(io, md->io_pool);
}
-static inline struct deferred_io *alloc_deferred(void)
-{
- return kmalloc(sizeof(struct deferred_io), GFP_NOIO);
-}
-
-static inline void free_deferred(struct deferred_io *di)
-{
- kfree(di);
-}
-
/*
* Add the bio to the list of deferred io.
*/
static int queue_io(struct mapped_device *md, struct bio *bio)
{
- struct deferred_io *di;
-
- di = alloc_deferred();
- if (!di)
- return -ENOMEM;
-
down_write(&md->lock);
if (!test_bit(DMF_BLOCK_IO, &md->flags)) {
up_write(&md->lock);
- free_deferred(di);
return 1;
}
- di->bio = bio;
- di->next = md->deferred;
- md->deferred = di;
+ bio->bi_next = md->deferred;
+ md->deferred = bio;
up_write(&md->lock);
return 0; /* deferred successfully */
@@ -743,14 +720,14 @@
/*
* Requeue the deferred bios by calling generic_make_request.
*/
-static void flush_deferred_io(struct deferred_io *c)
+static void flush_deferred_io(struct bio *c)
{
- struct deferred_io *n;
+ struct bio *n;
while (c) {
- n = c->next;
- generic_make_request(c->bio);
- free_deferred(c);
+ n = c->bi_next;
+ c->bi_next = NULL;
+ generic_make_request(c);
c = n;
}
}
@@ -832,7 +809,7 @@
int dm_resume(struct mapped_device *md)
{
- struct deferred_io *def;
+ struct bio *def;
down_write(&md->lock);
if (!md->map ||
next prev parent reply other threads:[~2004-02-10 17:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-10 16:35 dm core patches Joe Thornber
2004-02-10 16:57 ` [Patch 1/10] dm: Export dm_vcalloc() Joe Thornber
2004-02-10 16:59 ` [Patch 2/10] dm: Lift to_bytes() and to_sectors() into dm.h Joe Thornber
2004-02-10 16:59 ` Joe Thornber [this message]
2004-02-10 17:33 ` [Patch 3/10] dm: Get rid of struct dm_deferred_io in dm.c Christophe Saout
2004-02-10 17:00 ` [Patch 4/10] dm: Maintain ordering when deferring bios Joe Thornber
2004-02-10 17:00 ` [Patch 5/10] dm: Tidy up the error path for alloc_dev() Joe Thornber
2004-02-10 17:01 ` [Patch 6/10] dm: block size bug with 64 bit devs Joe Thornber
2004-02-10 17:01 ` [Patch 7/10] dm: Correct GFP flag in dm_table_create() Joe Thornber
2004-02-10 17:02 ` [Patch 8/10] dm: Zero size target sanity check Joe Thornber
2004-02-10 17:02 ` [Patch 9/10] dm: Remove redundant spin lock in dec_pending() Joe Thornber
2004-02-10 17:03 ` [Patch 10/10] dm: drop BIO_SEG_VALID bit Joe Thornber
2004-02-11 10:16 ` dm core patches Lars Marowsky-Bree
2004-02-11 10:35 ` Joe Thornber
2004-02-12 18:51 ` Lars Marowsky-Bree
2004-02-12 20:13 ` Joe Thornber
2004-02-13 15:12 ` Lars Marowsky-Bree
2004-02-13 15:39 ` Joe Thornber
2004-02-13 16:08 ` Arjan van de Ven
2004-02-16 8:19 ` Lars Marowsky-Bree
2004-02-16 9:35 ` Arjan van de Ven
2004-02-13 23:46 ` Mike Anderson
2004-02-16 12:17 ` Heinz Mauelshagen
2004-02-13 16:03 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040210165933.GI27507@reti \
--to=thornber@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox