Re: [ANNOUNCE] udev 016 release

Martin Schlemmer
2004-02-03T23:03:18Z

[-- Attachment #1.1: Type: text/plain, Size: 791 bytes --]

On Tue, 2004-02-03 at 23:28, Martin Schlemmer wrote:
> On Tue, 2004-02-03 at 22:13, Greg KH wrote:
>
> Except if I miss something major, udevsend and udevd still do not
> work:
>

Skip that, it does work if SEQNUM is set :P

Anyhow, is it _really_ needed for SEQNUM to be set? What about
the attached patch?

Then, order I have not really checked yet, but there are two things
that bother me:

1) latency is even higher than before (btw Greg, is there going to be
more sysfs/whatever fixes to get udev even faster, or is this the
limit?)

2) events gets missing. If you for example use udevsend in the
initscript that populate /dev (/udev), the amount of nodes/links
created is off with about 10-50 (once about 250) entries.

Thanks,

--
Martin Schlemmer

[-- Attachment #1.2: udev-016-udevsend-missing-seqnum.patch --]
[-- Type: text/x-patch, Size: 405 bytes --]

--- udev-016/udevsend.c 2004-02-04 00:55:23.522428312 +0200
+++ udev-016.seqnum/udevsend.c 2004-02-04 00:57:37.898000120 +0200
@@ -149,10 +149,14 @@

seqnum = get_seqnum();
if (seqnum == NULL) {
+#if 0
dbg("no seqnum");
goto exit;
+#endif
+ seq = 1;
+ } else {
+ seq = atoi(seqnum);
}
- seq = atoi(seqnum);

sock = socket(AF_LOCAL, SOCK_STREAM, 0);
if (sock == -1) {