public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kasprzak <kas@informatics.muni.cz>
To: "David S. Miller" <davem@redhat.com>
Cc: yoshfuji@linux-ipv6.org, linux-kernel@vger.kernel.org,
	kuznet@ms2.inr.ac.ru
Subject: Re: [Patch] Netlink BUG() on AMD64
Date: Thu, 12 Feb 2004 05:10:10 +0100	[thread overview]
Message-ID: <20040212051009.A16112@fi.muni.cz> (raw)
In-Reply-To: <20040211194909.0ab130cc.davem@redhat.com>; from davem@redhat.com on Wed, Feb 11, 2004 at 07:49:09PM -0800

David S. Miller wrote:
: Both fixes applied, thanks guys.
: 
: I was tempted to make skb_put()'s second argument signed, but I'm in no mood
: to audit the entire tree for that :-)

	I have grep'd the kernel for all occurences of rtattr_failure
and nlmsg_failure, and there are no more skb_put()s than those two
(hmm, legacy protocols which no-one uses, such as Decnet or IPv4 :-).
However, the same problem is in 2.4, so please push these fixes to
Marcelo as well.

-Yenya

-- 
| Jan "Yenya" Kasprzak  <kas at {fi.muni.cz - work | yenya.net - private}> |
| GPG: ID 1024/D3498839      Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E |
| http://www.fi.muni.cz/~kas/   Czech Linux Homepage: http://www.linux.cz/ |
 Any compiler or language that likes to hide things like memory allocations
 behind your back just isn't a good choice for a kernel.   --Linus Torvalds

  reply	other threads:[~2004-02-12  4:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-05 17:36 Netlink BUG() on AMD64 Jan Kasprzak
2004-02-11 18:11 ` [Patch] " Jan Kasprzak
2004-02-11 18:45   ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-11 18:58     ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-12  3:49       ` David S. Miller
2004-02-12  4:10         ` Jan Kasprzak [this message]
2004-02-12  4:23           ` David S. Miller
2004-02-12 14:05         ` kuznet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040212051009.A16112@fi.muni.cz \
    --to=kas@informatics.muni.cz \
    --cc=davem@redhat.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox