public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: linux-kernel@vger.kernel.org, Meelis Roos <mroos@linux.ee>
Subject: Re: Strange atkbd messages with missing keyboard
Date: Fri, 13 Feb 2004 17:46:15 -0500	[thread overview]
Message-ID: <200402131746.15884.dtor_core@ameritech.net> (raw)
In-Reply-To: <20040213185744.GA1371@ucw.cz>

On Friday 13 February 2004 01:57 pm, Vojtech Pavlik wrote:
> On Fri, Feb 13, 2004 at 01:27:46PM -0500, Dmitry Torokhov wrote:

> > I see that we are not getting a NAK when querying ID but getting it while
> > setting LEDs (or even writing to the control register later). It seems
> > like controller's timeout is longer than our internal one so we getting
> > timeout signal from keyboard (which we convert to a NAK) too late.
> 
> We don't convert it to a NAK, it comes as a NAK byte from the controller
> (generated by the controller), and with the timeout flag set.

Right, sorry I got confused with something else...

> 
> > I wonder if changing timeout in atkbd_sendbyte to 400 or 500 ms will
> > cure the problem.
> 
> It probably would, but it also would slow down the detection. I think we
> can simply ignore bytes with the timeout flag set in the atkbd_interrupt
> function when we're not expecting an ACK/NAK.
> 

The problem with this approach is that if late NAK comes while we are
actually waiting for result of some other command it will interfere and 
can cause misdetection.

-- 
Dmitry

  reply	other threads:[~2004-02-13 22:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-12 14:18 Strange atkbd messages with missing keyboard Meelis Roos
2004-02-12 14:46 ` Andries Brouwer
2004-02-12 21:36   ` Vojtech Pavlik
2004-02-13 13:12     ` Meelis Roos
2004-02-13 18:27       ` Dmitry Torokhov
2004-02-13 18:57         ` Vojtech Pavlik
2004-02-13 22:46           ` Dmitry Torokhov [this message]
2004-02-14  9:59             ` Vojtech Pavlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200402131746.15884.dtor_core@ameritech.net \
    --to=dtor_core@ameritech.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox