public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vojtech Pavlik <vojtech@suse.cz>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org, Meelis Roos <mroos@linux.ee>
Subject: Re: Strange atkbd messages with missing keyboard
Date: Fri, 13 Feb 2004 19:57:44 +0100	[thread overview]
Message-ID: <20040213185744.GA1371@ucw.cz> (raw)
In-Reply-To: <200402131327.46543.dtor_core@ameritech.net>

On Fri, Feb 13, 2004 at 01:27:46PM -0500, Dmitry Torokhov wrote:
> On Friday 13 February 2004 08:12 am, Meelis Roos wrote:
> > > Meelis, can you please enable DEBUG in i8042.c, so that I can check
> > > where these unexpected NAKs come from?
> > 
> > Here is full dmesg (though probably only the serio and atkbd lines are
> > interesting).
> > 
> 
> > drivers/input/serio/i8042.c: d4 -> i8042 (command) [3]
> > drivers/input/serio/i8042.c: f2 -> i8042 (parameter) [3]
> > drivers/input/serio/i8042.c: d4 -> i8042 (command) [109]
> > drivers/input/serio/i8042.c: ed -> i8042 (parameter) [109]
> > drivers/input/serio/i8042.c: fe <- i8042 (interrupt, aux, 12, timeout) [122]
> > drivers/input/serio/i8042.c: 60 -> i8042 (command) [122]
> > drivers/input/serio/i8042.c: 54 -> i8042 (parameter) [122]
> > drivers/input/serio/i8042.c: fe <- i8042 (interrupt, aux, 12, timeout) [240]
> > atkbd.c: Unknown key pressed (raw set 0, code 0x17e on isa0060/serio1).
> > atkbd.c: Use 'setkeycodes 7e <keycode>' to make it known.
> 
> I see that we are not getting a NAK when querying ID but getting it while
> setting LEDs (or even writing to the control register later). It seems
> like controller's timeout is longer than our internal one so we getting
> timeout signal from keyboard (which we convert to a NAK) too late.

We don't convert it to a NAK, it comes as a NAK byte from the controller
(generated by the controller), and with the timeout flag set.

> I wonder if changing timeout in atkbd_sendbyte to 400 or 500 ms will
> cure the problem.

It probably would, but it also would slow down the detection. I think we
can simply ignore bytes with the timeout flag set in the atkbd_interrupt
function when we're not expecting an ACK/NAK.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

  reply	other threads:[~2004-02-13 18:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-12 14:18 Strange atkbd messages with missing keyboard Meelis Roos
2004-02-12 14:46 ` Andries Brouwer
2004-02-12 21:36   ` Vojtech Pavlik
2004-02-13 13:12     ` Meelis Roos
2004-02-13 18:27       ` Dmitry Torokhov
2004-02-13 18:57         ` Vojtech Pavlik [this message]
2004-02-13 22:46           ` Dmitry Torokhov
2004-02-14  9:59             ` Vojtech Pavlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040213185744.GA1371@ucw.cz \
    --to=vojtech@suse.cz \
    --cc=dtor_core@ameritech.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox