From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267209AbUBMU76 (ORCPT ); Fri, 13 Feb 2004 15:59:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267214AbUBMU75 (ORCPT ); Fri, 13 Feb 2004 15:59:57 -0500 Received: from mail.kroah.org ([65.200.24.183]:30644 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S267209AbUBMU74 (ORCPT ); Fri, 13 Feb 2004 15:59:56 -0500 Date: Fri, 13 Feb 2004 12:38:28 -0800 From: Greg KH To: Stephen Hemminger Cc: Tommi Virtanen , Leann Ogasawara , netdev@oss.sgi.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] propogate errors from misc_register to caller Message-ID: <20040213203827.GC14048@kroah.com> References: <20040213102755.27cf4fcd.shemminger@osdl.org> <20040213112100.4f42abc2@dell_ss3.pdx.osdl.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040213112100.4f42abc2@dell_ss3.pdx.osdl.net> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 13, 2004 at 11:21:00AM -0800, Stephen Hemminger wrote: > The patch to check for / in class_device is not enough. > The misc_register function needs to check return value of the things it calls! Thanks, I'll go add this to my queue. greg k-h