From: Andi Kleen <ak@suse.de>
To: Alex Pankratov <ap@swapped.cc>
Cc: acme@conectiva.com.br, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [2.6] [1/2] hlist: replace explicit checks of hlist fields w/ func calls
Date: Sat, 14 Feb 2004 01:28:05 +0100 [thread overview]
Message-ID: <20040214012805.52e4af60.ak@suse.de> (raw)
In-Reply-To: <4029D267.40307@swapped.cc>
On Tue, 10 Feb 2004 22:57:43 -0800
Alex Pankratov <ap@swapped.cc> wrote:
> Ugh, yeah, I thought about this. However my understand was that
> since hlist_null is statically allocated variable, its address
> will be a known constant at a link time (whether it's a static
> link or dynamic/run-time link - btw, excuse my lack of proper
> terminology here). So comparing something to &null would be
> equivalent to comparing to the constant and not require an
> extra register.
Hmm, you're right. Apparently I was still thinking about the bad
code generated by the standard list_heads. I guess it would be ok then.
Still your first patch was rather intrusive regarding interface changes,
so it may be a good idea to wait for 2.7 with this.
-Andi
next prev parent reply other threads:[~2004-02-11 7:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-11 6:28 [PATCH] [2.6] [1/2] hlist: replace explicit checks of hlist fields w/ func calls Alex Pankratov
2004-02-13 22:14 ` Andi Kleen
2004-02-11 6:57 ` Alex Pankratov
2004-02-11 12:10 ` Arnaldo Carvalho de Melo
2004-02-14 0:28 ` Andi Kleen [this message]
2004-02-11 16:37 ` Alex Pankratov
2004-02-12 4:52 ` Alex Pankratov
2004-02-12 8:43 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040214012805.52e4af60.ak@suse.de \
--to=ak@suse.de \
--cc=acme@conectiva.com.br \
--cc=ap@swapped.cc \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox