public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>, zippel@linux-m68k.org
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.3-rc3: twice defined symbols with new radeonfb
Date: Sun, 15 Feb 2004 14:22:38 +0100	[thread overview]
Message-ID: <20040215132237.GS1308@fs.tum.de> (raw)
In-Reply-To: <1076831240.6960.35.camel@gaston>

On Sun, Feb 15, 2004 at 06:47:21PM +1100, Benjamin Herrenschmidt wrote:
> On Sun, 2004-02-15 at 18:41, Adrian Bunk wrote:
> > On Sat, Feb 14, 2004 at 07:33:45PM -0800, Linus Torvalds wrote:
> > >...
> > > Summary of changes from v2.6.3-rc2 to v2.6.3-rc3
> > > ============================================
> > >...
> > > Benjamin Herrenschmidt:
> > >...
> > >   o New radeonfb
> > >...
> > 
> > I'm getting the following compile error (no module support in the 
> > kernel):
> 
> Yes, you can't build both old and new radeonfb's at the same time,
> I should do some Kconfig stuff to check that I beleive. It make
> no sense as you don't know which one will pick up anyway.

Something like the patch below?

@Roman:
With the patch below, "make menuconfig" shows
       [ ]   ATI Radeon display support
         [*]     ATI Radeon display support (Old driver)
 
How can I void that the old driver is shown as if it was an option for 
the new driver?  

> Ben.

cu
Adrian

--- linux-2.6.3-rc3-full/drivers/video/Kconfig.old	2004-02-15 14:13:28.000000000 +0100
+++ linux-2.6.3-rc3-full/drivers/video/Kconfig	2004-02-15 14:20:00.000000000 +0100
@@ -614,16 +614,6 @@
 	  There is no need for enabling 'Matrox multihead support' if you have
 	  only one Matrox card in the box.
 
-config FB_RADEON_OLD
-	tristate "ATI Radeon display support (Old driver)"
-	depends on FB && PCI
-	help
-	  Choose this option if you want to use an ATI Radeon graphics card as
-	  a framebuffer device.  There are both PCI and AGP versions.  You
-	  don't need to choose this to run the Radeon in plain VGA mode.
-	  There is a product page at
-	  <http://www.ati.com/na/pages/products/pc/radeon32/index.html>.
-
 config FB_RADEON
 	tristate "ATI Radeon display support"
 	depends on FB && PCI
@@ -650,6 +640,16 @@
 	help
 	  Say Y here if you want DDC/I2C support for your Radeon board. 
 
+config FB_RADEON_OLD
+	tristate "ATI Radeon display support (Old driver)"
+	depends on FB && PCI && FB_RADEON!=y
+	help
+	  Choose this option if you want to use an ATI Radeon graphics card as
+	  a framebuffer device.  There are both PCI and AGP versions.  You
+	  don't need to choose this to run the Radeon in plain VGA mode.
+	  There is a product page at
+	  <http://www.ati.com/na/pages/products/pc/radeon32/index.html>.
+
 config FB_ATY128
 	tristate "ATI Rage128 display support"
 	depends on FB && PCI

  reply	other threads:[~2004-02-15 13:22 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-15  3:33 Linux 2.6.3-rc3 Linus Torvalds
2004-02-15  7:41 ` 2.6.3-rc3: twice defined symbols with new radeonfb Adrian Bunk
2004-02-15  7:47   ` Benjamin Herrenschmidt
2004-02-15 13:22     ` Adrian Bunk [this message]
2004-02-15 19:19       ` Roman Zippel
2004-02-15  9:17 ` Linux 2.6.3-rc3 Peter Osterlund
2004-02-15  9:54   ` Benjamin Herrenschmidt
2004-02-15 10:25     ` Benjamin Herrenschmidt
2004-02-15 10:51       ` Peter Osterlund
2004-02-15 11:11         ` Benjamin Herrenschmidt
2004-02-15 11:21         ` Geert Uytterhoeven
2004-02-15 10:33     ` Peter Osterlund
2004-02-15 15:03   ` Jonathan Brown
2004-02-15 16:05   ` Tomas Szepe
2004-02-15 16:44   ` Onur Kucuk
2004-02-16 15:58     ` Moritz Muehlenhoff
2004-02-17 16:29       ` Moritz Muehlenhoff
2004-02-15 19:52   ` Ernst Herzberg
2004-02-15 20:11     ` Peter Osterlund
2004-02-15 21:52       ` Ernst Herzberg
2004-02-15 22:29         ` Benjamin Herrenschmidt
     [not found]           ` <200402152357.25751.earny@net4u.de>
2004-02-15 23:08             ` Benjamin Herrenschmidt
     [not found]               ` <200402160033.43438.earny@net4u.de>
2004-02-15 23:54                 ` Benjamin Herrenschmidt
2004-02-16  0:29                   ` Ernst Herzberg
2004-02-16  0:38                     ` Ernst Herzberg
2004-02-16  0:43                       ` Benjamin Herrenschmidt
2004-02-16  1:18                         ` Ernst Herzberg
2004-02-16  1:47                           ` Benjamin Herrenschmidt
2004-02-16  0:41                     ` Benjamin Herrenschmidt
     [not found]                   ` <124101c3f435$9a66d3a0$1225a8c0@kittycat>
2004-02-16  2:37                     ` Benjamin Herrenschmidt
2004-02-15 22:27       ` Benjamin Herrenschmidt
     [not found]         ` <200402160005.47892.anib@uni-paderborn.de>
2004-02-15 23:11           ` Benjamin Herrenschmidt
2004-02-16 19:18 ` Linux 2.6.3-rc3 (compile stats) John Cherry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040215132237.GS1308@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox