public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: BlaisorBlade <blaisorblade_spam@yahoo.it>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Trivial -critical : BUG()gy behaviour on OOM
Date: Sun, 15 Feb 2004 16:01:50 -0800	[thread overview]
Message-ID: <20040216000150.GD631@holomorphy.com> (raw)
In-Reply-To: <200402151647.39907.blaisorblade_spam@yahoo.it>

On Sun, Feb 15, 2004 at 04:47:39PM +0100, BlaisorBlade wrote:
> In short: in vanilla 2.6.3-rc2 (and also 2.6.2-mm1) do_swap_page() can return 
> -ENOMEM while value return values are VM_FAULT_*; invalid return values can 
> result in BUG() being called, so this patch (or a better fix) should go in 
> soon. This patch corrects this by returning VM_FAULT_OOM in that case.
> CC me on replies, please, as I'm not subscribed. Thanks.
> In detail: do_swap_page returns -ENOMEM when memory allocation fails; the 
> return value will in turn be returned by handle_pte_fault and handle_mm_fault 
> to this code in do_page_fault:

Yep. This is bust.
akpm please apply.


-- wli

      reply	other threads:[~2004-02-16  0:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-15 15:47 [PATCH] Trivial -critical : BUG()gy behaviour on OOM BlaisorBlade
2004-02-16  0:01 ` William Lee Irwin III [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040216000150.GD631@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=akpm@osdl.org \
    --cc=blaisorblade_spam@yahoo.it \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox