* kernel-smp on i386, too many arguments to function `aty128_find_mem_vbios'
@ 2004-02-16 9:23 Olaf Hering
2004-02-16 16:17 ` Dave Jones
0 siblings, 1 reply; 3+ messages in thread
From: Olaf Hering @ 2004-02-16 9:23 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linux-kernel
CC [M] drivers/video/aty/radeon_base.o
drivers/video/aty/radeon_base.c: In function `radeon_screen_blank':
drivers/video/aty/radeon_base.c:945: warning: `val2' might be used uninitialized in this function
drivers/video/aty/radeon_base.c: In function `radeonfb_setcolreg':
drivers/video/aty/radeon_base.c:1026: warning: `vclk_cntl' might be used uninitialized in this function
drivers/video/aty/radeon_base.c: In function `radeonfb_set_par':
drivers/video/aty/radeon_base.c:1320: warning: `pll_output_freq' might be used uninitialized in this function
CC [M] drivers/video/aty/radeon_pm.o
CC [M] drivers/video/aty/radeon_monitor.o
drivers/video/aty/radeon_monitor.c: In function `radeon_match_mode':
drivers/video/aty/radeon_monitor.c:865: warning: passing arg 1 of `fb_validate_mode' discards qualifiers from pointer target type
CC [M] drivers/video/aty/radeon_accel.o
CC [M] drivers/video/aty/radeon_i2c.o
LD [M] drivers/video/aty/atyfb.o
CC [M] drivers/video/aty/aty128fb.o
drivers/video/aty/aty128fb.c: In function `aty128_probe':
drivers/video/aty/aty128fb.c:1955: error: too many arguments to function `aty128_find_mem_vbios'
make[3]: *** [drivers/video/aty/aty128fb.o] Error 1
make[2]: *** [drivers/video/aty] Error 2
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2
current bk.
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: kernel-smp on i386, too many arguments to function `aty128_find_mem_vbios'
2004-02-16 9:23 kernel-smp on i386, too many arguments to function `aty128_find_mem_vbios' Olaf Hering
@ 2004-02-16 16:17 ` Dave Jones
2004-02-16 21:51 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Dave Jones @ 2004-02-16 16:17 UTC (permalink / raw)
To: Olaf Hering; +Cc: Benjamin Herrenschmidt, linux-kernel
On Mon, Feb 16, 2004 at 10:23:50AM +0100, Olaf Hering wrote:
>
> CC [M] drivers/video/aty/radeon_base.o
> drivers/video/aty/radeon_base.c: In function `radeon_screen_blank':
> drivers/video/aty/radeon_base.c:945: warning: `val2' might be used uninitialized in this function
> drivers/video/aty/radeon_base.c: In function `radeonfb_setcolreg':
> drivers/video/aty/radeon_base.c:1026: warning: `vclk_cntl' might be used uninitialized in this function
> drivers/video/aty/radeon_base.c: In function `radeonfb_set_par':
> drivers/video/aty/radeon_base.c:1320: warning: `pll_output_freq' might be used uninitialized in this function
> CC [M] drivers/video/aty/radeon_pm.o
> CC [M] drivers/video/aty/radeon_monitor.o
> drivers/video/aty/radeon_monitor.c: In function `radeon_match_mode':
> drivers/video/aty/radeon_monitor.c:865: warning: passing arg 1 of `fb_validate_mode' discards qualifiers from pointer target type
> CC [M] drivers/video/aty/radeon_accel.o
> CC [M] drivers/video/aty/radeon_i2c.o
> LD [M] drivers/video/aty/atyfb.o
> CC [M] drivers/video/aty/aty128fb.o
> drivers/video/aty/aty128fb.c: In function `aty128_probe':
> drivers/video/aty/aty128fb.c:1955: error: too many arguments to function `aty128_find_mem_vbios'
> make[3]: *** [drivers/video/aty/aty128fb.o] Error 1
> make[2]: *** [drivers/video/aty] Error 2
> make[1]: *** [drivers/video] Error 2
> make: *** [drivers] Error 2
Looks straightforward enough...
Dave
--- linux-2.6.2/drivers/video/aty/aty128fb.c~ 2004-02-16 14:39:19.000000000 +0000
+++ linux-2.6.2/drivers/video/aty/aty128fb.c 2004-02-16 14:40:25.000000000 +0000
@@ -1952,7 +1952,7 @@
bios = aty128_map_ROM(par, pdev);
#ifdef __i386__
if (bios == NULL)
- bios = aty128_find_mem_vbios(par, pdev);
+ bios = aty128_find_mem_vbios(par);
#endif
if (bios == NULL)
printk(KERN_INFO "aty128fb: BIOS not located, guessing timings.\n");
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: kernel-smp on i386, too many arguments to function `aty128_find_mem_vbios'
2004-02-16 16:17 ` Dave Jones
@ 2004-02-16 21:51 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2004-02-16 21:51 UTC (permalink / raw)
To: Dave Jones; +Cc: Olaf Hering, Linux Kernel list
>
> Looks straightforward enough...
Yes, sent a patch already. I tested building this function, but not
building the function & the call to it :) (it's __i386__ and I'm on
ppc). Sorry.
Ben.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-02-16 21:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-16 9:23 kernel-smp on i386, too many arguments to function `aty128_find_mem_vbios' Olaf Hering
2004-02-16 16:17 ` Dave Jones
2004-02-16 21:51 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox