From: Andi Kleen <ak@suse.de>
To: linux-kernel@vger.kernel.org, akpm@osdl.org, mingo@elte.hu
Subject: [PATCH] Disable useless bootmem warning
Date: Mon, 16 Feb 2004 18:00:28 +0100 [thread overview]
Message-ID: <20040216180028.06402e70.ak@suse.de> (raw)
This bootmem warning has been annoying me forever:
hm, page 000f5000 reserved twice.
hm, page 000f6000 reserved twice.
hm, page 000f1000 reserved twice.
hm, page 000f2000 reserved twice.
It happens because the i386/x86-64 boot code prereserves the mptable and then later bootmem
tries to reserve it again because it's marked reserved in the e820 map.
I've never seen a bug uncovered by this warning too. I considered to disable it
by passing a special array of "ok to reserve twice" regions, but on second thought
it is just best to remove it completely. Reserving things twice is not usually
an error.
This patch does this.
-Andi
--- linux-2.6.3rc2-amd64/mm/bootmem.c-o 2004-02-11 22:06:58.000000000 +0100
+++ linux-2.6.3rc2-amd64/mm/bootmem.c 2004-02-16 17:52:05.000000000 +0100
@@ -91,8 +91,7 @@
if (end > bdata->node_low_pfn)
BUG();
for (i = sidx; i < eidx; i++)
- if (test_and_set_bit(i, bdata->node_bootmem_map))
- printk("hm, page %08lx reserved twice.\n", i*PAGE_SIZE);
+ set_bit(i, bdata->node_bootmem_map);
}
static void __init free_bootmem_core(bootmem_data_t *bdata, unsigned long addr, unsigned long size)
next reply other threads:[~2004-02-16 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-16 17:00 Andi Kleen [this message]
2004-02-16 16:52 ` [PATCH] Disable useless bootmem warning Ben Collins
2004-02-16 19:13 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040216180028.06402e70.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox