Re: [PATCH] Reduce TLB flushing during process migration

David S. Miller
2004-02-17T18:09:07Z

On Tue, 17 Feb 2004 17:22:14 +0100
Manfred Spraul <manfred@colorfullife.com> wrote:

> >+ * we want a new context here. This eliminates TLB
> >+ * flushes on the cpus where the process executed prior to
> >+ * the migration.
> >+ */
> >+ flush_tlb_mm(current->mm);
...
> I think flush_tlb_mm() is the wrong function - e.g. for i386, it's a
> wasted flush, because i386 disconnects previous cpus from the tlb flush
> automatically.
> And it's always the wrong thing if you've migrated one thread of a task
> that runs on multiple cpus. I think you need a new hook.

Yes, you're probably right. Just name it tlb_migrate_prepare(mm) or
something like that.

I think most if not all non-x86 platforms will define this straight
to flush_tlb_mm().