public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@us.ibm.com>
To: Linda Xie <lxiep@linux.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	John Rose <johnrose@austin.ibm.com>,
	Rusty Russell <rusty@au1.ibm.com>,
	linux-kernel@vger.kernel.org, Mike Wortman <wortman@us.ibm.com>
Subject: Re: [PATCH] PPC64 PCI Hotplug Driver for RPA
Date: Wed, 18 Feb 2004 11:17:30 -0800	[thread overview]
Message-ID: <20040218191729.GA3254@us.ibm.com> (raw)
In-Reply-To: <4033B983.6060809@ltcfwd.linux.ibm.com>

On Wed, Feb 18, 2004 at 01:14:11PM -0600, Linda Xie wrote:
> >
> >If you have a method that per specification doesn't get a NULL pointer 
> >adding
> >these kinds of checks is bad.  Getting a NULL pointer would be against the
> >codified guaranteeds and your system already is bad trouble - better panic
> >ASAP by dereferencing the NULL pointer than waiting longer and possibly
> >corrupting data.
> > 
> >
> Well, I understand your point, but other php drivers do the same thing.
> 
> Greg,
> Any thoughts?

I was being overly cautious a long time ago when I wrote that code.
Actually the whole "magic number" stuff can go away too, as that's
pretty pointless...

But don't worry about that too much.  If you want to clean it up, I
don't care.

> updated patch attached.

Um, how about a whole new patch against 2.6.3 as I have not applied this
one...

thanks,

greg k-h

  parent reply	other threads:[~2004-02-18 19:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-11  1:08 [PATCH] PPC64 PCI Hotplug Driver for RPA johnrose
2004-02-15  8:58 ` Rusty Russell
2004-02-16 18:18   ` John Rose
2004-02-16 18:21   ` John Rose
2004-02-16 18:35     ` Christoph Hellwig
     [not found]       ` <4033B983.6060809@ltcfwd.linux.ibm.com>
2004-02-18 19:17         ` Greg KH [this message]
     [not found]           ` <4033CC29.3010508@ltcfwd.linux.ibm.com>
2004-02-18 20:57             ` Greg KH
2004-02-18 22:27         ` Rusty Russell
  -- strict thread matches above, loose matches on Subject: below --
2004-02-11  1:12 johnrose
2004-02-18 20:57 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040218191729.GA3254@us.ibm.com \
    --to=gregkh@us.ibm.com \
    --cc=hch@infradead.org \
    --cc=johnrose@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lxiep@linux.ibm.com \
    --cc=rusty@au1.ibm.com \
    --cc=wortman@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox