From: Andi Kleen <ak@suse.de>
To: Dave Jones <davej@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Enable Intel AGP on x86-64
Date: Thu, 19 Feb 2004 02:11:49 +0100 [thread overview]
Message-ID: <20040219021149.519d0754.ak@suse.de> (raw)
In-Reply-To: <20040218202325.GZ6242@redhat.com>
On Wed, 18 Feb 2004 20:23:25 +0000
Dave Jones <davej@redhat.com> wrote:
> On Wed, Feb 18, 2004 at 07:44:38PM +0000, Linux Kernel wrote:
> > ChangeSet 1.1564, 2004/02/18 11:44:38-08:00, ak@suse.de
> >
> > [PATCH] Enable Intel AGP on x86-64
> >
> > Enable the Intel AGP driver for x86-64 too.
>
> Please don't do this. At least copy intel-agp.c to
> something new and throw out all the dozens of chipsets
> that will never appear on ia32e.
>
> Splitting agpgart up to seperate drivers allowed us
> to stop adding cruft upon cruft with each generation
> of chipsets. I don't want to have to spend half of
> 2.7 decrufting agpgart again.
Huh? Did you actually read the patch? It doesn't change the AGP
driver at all, just enables it in Kconfig because Intel chipsets
can be now used on the x86-64 kernel too.
-Andi
next prev parent reply other threads:[~2004-02-18 20:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200402182006.i1IK6bL7022634@hera.kernel.org>
2004-02-18 20:23 ` [PATCH] Enable Intel AGP on x86-64 Dave Jones
2004-02-19 1:11 ` Andi Kleen [this message]
2004-02-18 20:44 ` Dave Jones
2004-02-19 2:55 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040219021149.519d0754.ak@suse.de \
--to=ak@suse.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox