Re: [PATCH] Enable Intel AGP on x86-64

[Andi Kleen <ak@suse.de>]

On Wed, 18 Feb 2004 20:44:06 +0000
Dave Jones <davej@redhat.com> wrote:

> On Thu, Feb 19, 2004 at 02:11:49AM +0100, Andi Kleen wrote:
> 
>  > > Please don't do this. At least copy intel-agp.c to
>  > > something new and throw out all the dozens of chipsets
>  > > that will never appear on ia32e.
>  > > 
>  > > Splitting agpgart up to seperate drivers allowed us
>  > > to stop adding cruft upon cruft with each generation
>  > > of chipsets.  I don't want to have to spend half of
>  > > 2.7 decrufting agpgart again.
>  > 
>  > Huh? Did you actually read the patch?
> 
> Yes, did you actually read my mail?

I guess I had expected it to make more sense, but it didn't.

> 
>  > It doesn't change the AGP driver at all, just enables it in Kconfig because
>  > Intel chipsets can be now used on the x86-64 kernel too.
> 
> You *really* think you're going to see a 440BX GART on ia32e ?
> i810 ? i820 ? i830 ? etc. etc. I'd be *very* surprised if anything
> but the current generation of ia32 chipsets gets used on ia32e.
> It just doesn't make sense.
> 
> Without even looking at the code I'll bet you can shrink it
> by at least 75%.

Feel free to do that. I don't have any plans to hack the Intel AGP driver
right now. 

-Andi