Re: [linux-usb-devel] Re: [BK PATCH] USB update for 2.6.3

David Brownell
2004-02-20T08:44:45Z

Deepak Saxena wrote:
> On Feb 20 2004, at 18:47, Benjamin Herrenschmidt was caught saying:
>
>>>If you mean the USB target device itself, can't you walk the
>>>tree until you find a device that is no longer on bus_type
>>>usb to determine your root?
>>
>>I don't feel like walking the tree on each pci_dma access

Why should that be needed though?

> I never said it would be pretty. :)

Well, usb_device->bus->controller is the only access that
should be needed ... much prettier than a tree walk! It's
set up as part of device enumeration.

Some of the usb_buffer_*() mapping calls could probably
start to get inlined now, using the generic DMA calls.

- Dave