Re: [BK PATCH] USB update for 2.6.3

Greg KH
2004-02-20T07:00:27Z

On Fri, Feb 20, 2004 at 05:42:56PM +1100, Benjamin Herrenschmidt wrote:
>
> > Well, we do. The pcibios_xxx routines get called for all PCI devices
> > during discovery, and that's when you'd fill them in.
>
> But what about USB or FireWire devices ? In theory, I'd like to see
> the driver for those not have to bother about beeing hosted by a PCI
> device or whatever else (there are typically non-PCI OHCI USBs on
> embedded platform, faking a pci_dev is becoming painful).

This is the main reason this patch was done. The arm people were
getting tired or having to do this for their USB controller drivers.
This round of patches (and the previous ones with the dmapool stuff)
removed that dependency.

As for how ARM deals with their devices on non-pci busses, I really do
not know, I never looked into that.

But for PPC64 this should not be a problem, as all of the code should
just work the same as it did before because you only have PCI based USB
controllers, right? Odds are your header files just don't include the
same files so Linus's patch should be all that is needed.

As for the bigger "generic" dma mapping discussions for devices, hasn't
this been hashed out a bunch already? For some reason I thought
everyone was happy for now with the way things work, and for 2.7 it was
going to be expanded a bit to help support non-pci based busses (much
like the ARM people just did.)

Hm, I wonder if I can convince anyone that I have to have a PPC64 box
now to make sure I don't break the build anytime in the future :)

thanks,

greg k-h