From: Andi Kleen <ak@suse.de>
To: Philippe Elie <phil.el@wanadoo.fr>
Cc: jakub@redhat.com, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: [PATCH] Fix typo in x86-64 fix
Date: Fri, 20 Feb 2004 20:32:28 +0100 [thread overview]
Message-ID: <20040220203228.7846bf32.ak@suse.de> (raw)
In-Reply-To: <20040219212002.GC382@zaniah>
On Thu, 19 Feb 2004 21:20:02 +0000
Philippe Elie <phil.el@wanadoo.fr> wrote:
> On Fri, 20 Feb 2004 at 17:44 +0000, Andi Kleen wrote:
>
> > > > +#ifdef CONFIG_SMP_
> > >
> > > ^ Isn't this a typo?
> >
> > Indeed. Thanks for catching it.
> >
> > It probably doesn't hurt because I don't know of any module that uses cpu_sibling_map[].
> > I think I just copied the export from i386. Maybe it would be best to just remove it completely.
>
> Andrew added it a few hours ago, oprofile use it.
Ok, Andrew, can you please apply this incremental patch to fix the typo too ?
diff -u linux-2.6.3-amd64/arch/x86_64/kernel/x8664_ksyms.c-o linux-2.6.3-amd64/arch/x86_64/kernel/x8664_ksyms.c
--- linux-2.6.3-amd64/arch/x86_64/kernel/x8664_ksyms.c-o 2004-02-20 15:53:53.000000000 +0100
+++ linux-2.6.3-amd64/arch/x86_64/kernel/x8664_ksyms.c 2004-02-20 20:25:03.000000000 +0100
@@ -194,7 +194,7 @@
EXPORT_SYMBOL(die_chain);
-#ifdef CONFIG_SMP_
+#ifdef CONFIG_SMP
EXPORT_SYMBOL(cpu_sibling_map);
#endif
-Andi
next prev parent reply other threads:[~2004-02-19 21:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-19 18:34 Intel x86-64 support patch breaks amd64 Tony Lindgren
2004-02-20 16:13 ` Andi Kleen
2004-02-19 19:36 ` Jakub Jelinek
2004-02-20 16:44 ` Andi Kleen
2004-02-19 21:20 ` Philippe Elie
2004-02-20 19:32 ` Andi Kleen [this message]
2004-02-19 20:39 ` Tony Lindgren
2004-02-20 19:02 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040220203228.7846bf32.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jakub@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phil.el@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox