public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Willy Tarreau <willy@w.ods.org>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.25-rc4
Date: Sun, 22 Feb 2004 23:03:00 +0100	[thread overview]
Message-ID: <20040222220259.GA24668@elf.ucw.cz> (raw)
In-Reply-To: <20040222084153.GA20189@alpha.home.local>

Hi!

> > > Your fix looks ok. I dont think calling acpi_system_save_state(S5) can
> > > cause any breakage. Len?
> > 
> > I bet it will create "machine will reboot instead of poweroff" on some
> > strange machine.... Perhaps it fixes more machines than it breaks, but
> > it will probably break some.
> 
> This is interesting. Do you have an idea about what could break
> exactly ?

No, but this is ACPI. No matter how simple change looks, it will break
something.

> In my case, I have noticed two things :
>   - if I disable local APIC, the standard code works
>   - if I enable local APIC, I need the patch above.
> 
> So perhaps it would be enough to disable local APIC instead of calling this
> function ?

Hmm.. that means we need APIC driver model...
									Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]

  reply	other threads:[~2004-02-22 22:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-18  5:11 Linux 2.4.25-rc4 Marcelo Tosatti
2004-02-18  5:57 ` Willy Tarreau
2004-02-18 14:34   ` Marcelo Tosatti
2004-02-18 21:27     ` Willy Tarreau
2004-02-20 22:48     ` Pavel Machek
2004-02-22  8:41       ` Willy Tarreau
2004-02-22 22:03         ` Pavel Machek [this message]
2004-02-18 19:17 ` Hilko Bengen
2004-02-19 19:39   ` Marcelo Tosatti
2004-02-19 23:28     ` Hilko Bengen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040222220259.GA24668@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=willy@w.ods.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox