From: viro@parcelfarce.linux.theplanet.co.uk
To: Ian Wienand <ianw@gelato.unsw.edu.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] devpts_fs.h fails with "error: parameter name omitted"
Date: Tue, 24 Feb 2004 02:24:24 +0000 [thread overview]
Message-ID: <20040224022424.GL31035@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040224021651.GF1200@cse.unsw.EDU.AU>
On Tue, Feb 24, 2004 at 01:16:51PM +1100, Ian Wienand wrote:
> -int devpts_pty_new(struct tty_struct *); /* mknod in devpts */
> -struct tty_struct *devpts_get_tty(int); /* get tty structure */
> -void devpts_pty_kill(int); /* unlink */
> +int devpts_pty_new(struct tty_struct *tty); /* mknod in devpts */
> +struct tty_struct *devpts_get_tty(int number); /* get tty structure */
> +void devpts_pty_kill(int number); /* unlink */
> /* Dummy stubs in the no-pty case */
> -static inline int devpts_pty_new(struct tty_struct *) { return -EINVAL; }
> -static inline struct tty_struct *devpts_get_tty(int) { return NULL; }
> -static inline void devpts_pty_kill(int) { }
> +static inline int devpts_pty_new(struct tty_struct *tty) { return -EINVAL; }
> +static inline struct tty_struct *devpts_get_tty(int number) { return NULL; }
> +static inline void devpts_pty_kill(int number) { }
That part makes sense. Previous one doesn't.
next prev parent reply other threads:[~2004-02-24 2:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-24 2:16 [PATCH] devpts_fs.h fails with "error: parameter name omitted" Ian Wienand
2004-02-24 2:24 ` viro [this message]
2004-02-24 2:49 ` Ian Wienand
2004-02-24 3:00 ` viro
2004-02-24 4:31 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040224022424.GL31035@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=ianw@gelato.unsw.edu.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox