Re: [PATCH] devpts_fs.h fails with "error: parameter name omitted"

viro
2004-02-24T02:24:26Z

On Tue, Feb 24, 2004 at 01:16:51PM +1100, Ian Wienand wrote:

> -int devpts_pty_new(struct tty_struct *); /* mknod in devpts */
> -struct tty_struct *devpts_get_tty(int); /* get tty structure */
> -void devpts_pty_kill(int); /* unlink */
> +int devpts_pty_new(struct tty_struct *tty); /* mknod in devpts */
> +struct tty_struct *devpts_get_tty(int number); /* get tty structure */
> +void devpts_pty_kill(int number); /* unlink */

> /* Dummy stubs in the no-pty case */
> -static inline int devpts_pty_new(struct tty_struct *) { return -EINVAL; }
> -static inline struct tty_struct *devpts_get_tty(int) { return NULL; }
> -static inline void devpts_pty_kill(int) { }
> +static inline int devpts_pty_new(struct tty_struct *tty) { return -EINVAL; }
> +static inline struct tty_struct *devpts_get_tty(int number) { return NULL; }
> +static inline void devpts_pty_kill(int number) { }

That part makes sense. Previous one doesn't.