From: "David S. Miller" <davem@redhat.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: viro@parcelfarce.linux.theplanet.co.uk, hch@lst.de,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: Please back out the bluetooth sysfs support
Date: Tue, 24 Feb 2004 10:03:25 -0800 [thread overview]
Message-ID: <20040224100325.761f48eb.davem@redhat.com> (raw)
In-Reply-To: <1077621601.2880.27.camel@pegasus>
On Tue, 24 Feb 2004 12:20:01 +0100
Marcel Holtmann <marcel@holtmann.org> wrote:
> > > > - skb->dev = (void *) &bfusb->hdev;
> > > > + skb->dev = (void *) bfusb->hdev;
> > >
> > > Wait a bloody minute. skb->dev is supposed to be net_device; what's going
> > > on here?
> >
> > Oh yeah, this is busted.
> > I'm surprised this doesn't explode.
>
> we used this from the beginning and I don't see where this can explode,
> because the SKB's are only used inside the Bluetooth subsystem.
Ok, if that is %100 true, then it's OK.
next prev parent reply other threads:[~2004-02-24 18:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-23 10:36 Please back out the bluetooth sysfs support Christoph Hellwig
2004-02-23 18:12 ` David S. Miller
2004-02-23 18:22 ` Marcel Holtmann
2004-02-23 18:32 ` David S. Miller
2004-02-23 18:45 ` Christoph Hellwig
2004-02-24 0:25 ` Marcel Holtmann
2004-02-24 0:41 ` viro
2004-02-24 7:21 ` David S. Miller
2004-02-24 11:20 ` Marcel Holtmann
2004-02-24 18:03 ` David S. Miller [this message]
2004-02-24 19:26 ` Marcel Holtmann
2004-02-25 8:10 ` David S. Miller
2004-02-25 17:40 ` Marcel Holtmann
2004-02-25 18:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040224100325.761f48eb.davem@redhat.com \
--to=davem@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox