From: Greg KH <greg@kroah.com>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: Kai Makisara <Kai.Makisara@metla.fi>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
kai.makisara@kolumbus.fi
Subject: Re: [BK PATCH] SCSI update for 2.6.3
Date: Tue, 24 Feb 2004 09:16:29 -0800 [thread overview]
Message-ID: <20040224171629.GA31369@kroah.com> (raw)
In-Reply-To: <1077642529.1804.170.camel@mulgrave>
On Tue, Feb 24, 2004 at 11:08:48AM -0600, James Bottomley wrote:
> On Tue, 2004-02-24 at 11:04, Greg KH wrote:
> > Can you post it here so we can review it?
> >
> > And yes, using class_simple should relieve you of Al flamage :)
>
> The one in the tree is attached. I did verify it myself, and tried it
> out on some old QIC tapes I had lying around.
Can you print out the sysfs tree this patch creates?
What's that "tape" symlink for? Does it go from the scsi device in
/sys/devices/... to the class device? Or the other way around?
Other than that question, the patch looks sane to me.
thanks,
greg k-h
next prev parent reply other threads:[~2004-02-24 17:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-24 7:30 [BK PATCH] SCSI update for 2.6.3 Kai Makisara
2004-02-24 17:04 ` Greg KH
2004-02-24 17:08 ` James Bottomley
2004-02-24 17:16 ` Greg KH [this message]
2004-02-24 17:33 ` Linus Torvalds
2004-02-24 17:51 ` Kai Makisara
2004-02-24 17:55 ` Greg KH
2004-02-24 18:15 ` Patrick Mansfield
2004-02-24 21:41 ` Greg KH
2004-02-24 21:48 ` Kai Makisara
2004-02-24 22:09 ` Greg KH
2004-02-24 22:32 ` Kai Makisara
-- strict thread matches above, loose matches on Subject: below --
2004-02-25 16:46 Moore, Eric Dean
2004-02-25 20:17 ` Joe Korty
2004-02-25 0:23 Moore, Eric Dean
2004-02-25 14:29 ` Joe Korty
2004-02-24 4:24 James Bottomley
2004-02-24 4:52 ` Linus Torvalds
2004-02-24 15:24 ` Joe Korty
2004-02-24 15:34 ` James Bottomley
2004-02-24 16:04 ` Joe Korty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040224171629.GA31369@kroah.com \
--to=greg@kroah.com \
--cc=James.Bottomley@steeleye.com \
--cc=Kai.Makisara@metla.fi \
--cc=akpm@osdl.org \
--cc=kai.makisara@kolumbus.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox