From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262320AbUBXRRN (ORCPT ); Tue, 24 Feb 2004 12:17:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262309AbUBXRQ6 (ORCPT ); Tue, 24 Feb 2004 12:16:58 -0500 Received: from mail.kroah.org ([65.200.24.183]:52115 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S262320AbUBXRQb (ORCPT ); Tue, 24 Feb 2004 12:16:31 -0500 Date: Tue, 24 Feb 2004 09:16:29 -0800 From: Greg KH To: James Bottomley Cc: Kai Makisara , Linus Torvalds , Andrew Morton , SCSI Mailing List , Linux Kernel , kai.makisara@kolumbus.fi Subject: Re: [BK PATCH] SCSI update for 2.6.3 Message-ID: <20040224171629.GA31369@kroah.com> References: <20040224170412.GA31268@kroah.com> <1077642529.1804.170.camel@mulgrave> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1077642529.1804.170.camel@mulgrave> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 24, 2004 at 11:08:48AM -0600, James Bottomley wrote: > On Tue, 2004-02-24 at 11:04, Greg KH wrote: > > Can you post it here so we can review it? > > > > And yes, using class_simple should relieve you of Al flamage :) > > The one in the tree is attached. I did verify it myself, and tried it > out on some old QIC tapes I had lying around. Can you print out the sysfs tree this patch creates? What's that "tape" symlink for? Does it go from the scsi device in /sys/devices/... to the class device? Or the other way around? Other than that question, the patch looks sane to me. thanks, greg k-h