From: Greg KH <greg@kroah.com>
To: Pat Gefre <pfg@sgi.com>
Cc: davidm@napali.hpl.hp.com, linux-kernel@vger.kernel.org,
linux-ia64@vger.kernel.org
Subject: Re: [2.6 PATCH] Altix hotplug
Date: Tue, 24 Feb 2004 13:38:07 -0800 [thread overview]
Message-ID: <20040224213807.GA2045@kroah.com> (raw)
In-Reply-To: <Pine.SGI.3.96.1040224131328.43293F-100000@fsgi900.americas.sgi.com>
On Tue, Feb 24, 2004 at 01:16:14PM -0600, Pat Gefre wrote:
> On Mon, 23 Feb 2004, Greg KH wrote:
>
> + On Mon, Feb 23, 2004 at 08:55:14AM -0600, Pat Gefre wrote:
> + > +#define SYSCTL_PCI_UNINITIALIZED (SYSCTL_PCI_ERROR_BASE - 0)
> + > + { SYSCTL_PCI_UNINITIALIZED, "module not initialized" },
> +
> + What are you going to do with this large table of strings? I see where
> + you copy them to somewhere, but don't see anything beyond that.
> +
> + Are we missing a huge piece of the puzzle?
>
> Greg,
>
> They are used in sysctl_pci_error_lookup(), which is called
> pcibr_slot_pwr(), which is the code to put a device on-line. It all
> traces back to the slot_enable call that is made from the hot plug
> driver (which is not included in this mod).
Ok, as stated before, please post both pieces so we can see if it even
makes sense for you to be splitting things up in this way (you realize
that no other pci hotplug driver needs to do it in this manner, right?)
thanks,
greg k-h
next prev parent reply other threads:[~2004-02-24 21:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-23 14:55 [2.6 PATCH] Altix hotplug Pat Gefre
2004-02-23 20:23 ` Greg KH
2004-02-24 19:12 ` Pat Gefre
2004-02-24 19:40 ` Greg KH
2004-02-23 21:04 ` Greg KH
2004-02-24 19:16 ` Pat Gefre
2004-02-24 21:38 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-02-20 21:11 Pat Gefre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040224213807.GA2045@kroah.com \
--to=greg@kroah.com \
--cc=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pfg@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox